Skip to content

Conversation

@georgwiese
Copy link
Collaborator

@georgwiese georgwiese commented Jan 1, 2026

This is fixing the same issue as #3510, seems like I overlooked two cases. Note that #3528 also updates reth, but I think it should not change anything.

The post merge test currently fails to build.

Another manual run that I started as part of #3522 builds but panics:

thread 'main' (2057679) panicked at /home/runner/.cargo/git/checkouts/openvm-77dd23e285a1262c/ab546e4/crates/vm/src/arch/record_arena.rs:95:47:
range end index 36 out of range for slice of length 0
stack backtrace:
   0: __rustc::rust_begin_unwind
   1: core::panicking::panic_fmt
   2: core::slice::index::slice_end_index_len_fail::do_panic::runtime
   3: core::slice::index::slice_end_index_len_fail
   4: <openvm_rv32im_circuit::base_alu::core::BaseAluExecutor<A,_,_> as openvm_circuit::arch::execution::PreflightExecutor<F,RA>>::execute
   5: <openvm_sdk::config::global::SdkVmConfigInnerExecutor<F> as openvm_circuit::arch::execution::PreflightExecutor<F,RA>>::execute
   6: <powdr_openvm::powdr_extension::executor::PowdrExecutor as openvm_circuit::arch::execution::PreflightExecutor<p3_monty_31::monty_31::MontyField31<p3_baby_bear::baby_bear::BabyBearParameters>>>::execute
   7: <powdr_openvm::SpecializedExecutor as openvm_circuit::arch::execution::PreflightExecutor<F,RA>>::execute
   8: openvm_circuit::arch::vm::VirtualMachine<E,VB>::execute_preflight
   9: openvm_sdk::prover::app::AppProver<E,VB>::prove
  10: openvm_reth_benchmark::run_reth_benchmark::{{closure}}::{{closure}}::{{closure}}
  11: tracing::span::Span::in_scope
  12: openvm_stark_sdk::bench::run_with_metric_collection
  13: openvm_reth_benchmark_bin::main::{{closure}}
  14: tokio::runtime::park::CachedParkThread::block_on
  15: openvm_reth_benchmark_bin::main
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.

github-merge-queue bot pushed a commit that referenced this pull request Jan 7, 2026
Successful post merge run here:
https://github.com/powdr-labs/powdr/actions/runs/20769075571/job/59641245254

Cherry picks from #3527 for the
`--mode` fix.
Depends on Reth PR:
powdr-labs/openvm-reth-benchmark#53
Depends on OVM main fix: powdr-labs/openvm#53

---------

Co-authored-by: Georg Wiese <[email protected]>
@qwang98
Copy link
Collaborator

qwang98 commented Jan 7, 2026

I think this can be closed as its only commit is cherry picked to #3537, which solved AOT and has been merged. @georgwiese

@leonardoalt
Copy link
Member

I guess we can close this now?

@georgwiese
Copy link
Collaborator Author

OK, cool!

@georgwiese georgwiese closed this Jan 8, 2026
@georgwiese georgwiese deleted the fix-mode-arg branch January 8, 2026 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants