Extend coding style guidelines in CLAUDE.md #3569
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add guidelines for keeping diffs small, using eyre::Result for error handling, and using builder pattern with with_* methods. Co-Authored-By: Claude Opus 4.5 <[email protected]>
georgwiese
commented
Jan 16, 2026
georgwiese
commented
Jan 16, 2026
Collaborator
Author
georgwiese
left a comment
georgwiese
left a comment
There was a problem hiding this comment.
Next time you open a PR, open a draft PR. Add that to Claude.md
Co-Authored-By: Claude Opus 4.5 <[email protected]>
Co-Authored-By: Claude Opus 4.5 <[email protected]>
leonardoalt
reviewed
Jan 16, 2026
| 3. Run relevant tests and / or end-to-end tests using the CLI | ||
|
|
||
| ### Git Workflow | ||
| - Use `git push origin <branchname>` |
Member
There was a problem hiding this comment.
this could use gh cli tool instead gh pr new eg
Member
There was a problem hiding this comment.
ah you already have that below
leonardoalt
approved these changes
Jan 16, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some small additions to CLAUDE.md, regarding coding style, when to return to the user and how to interact with GitHub.