feat(release): automate image releases with GoReleaser - #118
Closed
fdpeiter wants to merge 2 commits into
Closed
Conversation
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 24 hours if no further activity occurs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 What does this PR do?
Adds
.goreleaser.yamland.github/workflows/release.yml, modeled onpowerhome/pac-quota-controller's GoReleaser setup, to automate what's currently a manual release step. On every version tag push (e.g.1.4.2), this builds and pushes both thekeessandkeess-kubeconfig-reloaderimages to the internal Harbor registry (image-registry.powerapp.cloud/keess/...), and cuts a GitHub Release with auto-generated notes.Runs on
self-hosted(tracked separately: aRunnerDeploymentis being added topowerhome/pacso this workflow has a runner that can reach the internal registry). Docker login usesHARBOR_USERNAME/HARBOR_PASSWORDsecrets, following the same pattern aspowerhome/oncall-notifier's release workflow.🔍 Why? (Context)
Today, publishing the
keessandkubeconfig-reloaderimages is a manual step (make powerhome-build-and-publish) and Jenkins only builds the mainkeessimage to the internal registry, neverkubeconfig-reloader. This closes that gap and removes the manual publish step from the release checklist going forward.Checklist
🧪 How this was tested? And test results
goreleaser check— config validates (only a non-blocking deprecation notice aboutdockers→dockers_v2, same as used by pac-quota-controller/oncall-notifier today).goreleaser release --snapshot --clean --skip=publish,validatelocally — both Dockerfiles build successfully through GoReleaser's buildx path. The push step itself was not exercised locally (no Harbor credentials on this machine) — will be validated on the first real tag push once theHARBOR_USERNAME/HARBOR_PASSWORDsecrets and the self-hosted runner are in place.This workflow won't run successfully until:
powerhome/pachas aRunnerDeploymentforkeess(companion change, in progress)HARBOR_USERNAME/HARBOR_PASSWORDrepo secrets are added topowerhome/keessUntil then this is inert (no tags pushed yet), so safe to merge ahead of those.