fix(chart): let appVersion select the image instead of a pinned digest - #143
Open
L30Bola wants to merge 7 commits into
Open
fix(chart): let appVersion select the image instead of a pinned digest#143L30Bola wants to merge 7 commits into
L30Bola wants to merge 7 commits into
Conversation
Contributor
Author
|
Claude's debug: |
fdpeiter
approved these changes
Aug 26, 2026
fdpeiter
previously approved these changes
Aug 26, 2026
dgmorales
requested changes
Aug 26, 2026
Contributor
There was a problem hiding this comment.
We need to bump the helm chart version (not the app Version). So we then change that on pac addons defaults later, to fix our keess deployments.
Also I think we could revert this commit: b6f3d5f
that was added only for this undesired pinning to happen, and just makes the version logic more complex to understand.
fdpeiter
approved these changes
Aug 26, 2026
fdpeiter
previously approved these changes
Aug 26, 2026
L30Bola
enabled auto-merge (squash)
August 26, 2026 19:35
L30Bola
disabled auto-merge
August 26, 2026 19:36
L30Bola
enabled auto-merge (squash)
August 26, 2026 19:40
dgmorales
requested changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 What does this PR do?
Removes the version pinning introduced in #83
🔍 Why? (Context)
Because of that, we were updating the application and Helm Chart but we weren't shipping the actual changes.
Checklist
🧪 How this was tested? And test results
Tested locally. Check below commentNo special care needed.