[PLAY-3003] Playbook Website: Fix Small Expand-All and Sort Icons in Rails Advanced Table Header - #6222
Merged
Conversation
ElisaShapiro
added
milano
ElisaShapiro
changed the title
ElisaShapiro
marked this pull request as ready for review
May 27, 2026 20:53
kangaree
approved these changes
May 28, 2026
nidaqg
approved these changes
May 28, 2026
|
🎉 Congratulations on creating an Alpha Version! Your Alpha for Ruby Gems is 16.8.0.pre.alpha.PLAY3003websiteonlyiconboxsizing16656 Your Alpha for NPM is 16.8.0-alpha.PLAY3003websiteonlyiconboxsizing16656 |
ElisaShapiro
added
the
Ready for Release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do? A clear and concise description with your runway ticket url.
PLAY-3003 removing FA from the Playbook website entirely caused an icon size issue for a few Icon-containing kits. FA JS adds a <style> tag with
box-sizing: content-box- adding that rule back to the FA-based svg-inline--fa class helps put it back in the places where it was important.Relevant for Rails Advanced Table and React and Rails Icon Button - I did a website smoketest/check for many other icon-containing kits and none of them had this icon regression (all Icon_ kits, all Button kits, Badge, Collapsible, DatePicker, DateRangeInline, DateRangeStacked, Dialog, Dropdown, Filter, FixedConfirmationToast, LoadingInline, Nav, Passphrase, RichTextEditor, Select, Table, TextInput, TimeRangeInline, Typeahead).
Screenshots: Screenshots to visualize your addition/change
Current Prod - a few tiny icons:
Updated - icons back to normal:
How to test? Steps to confirm the desired behavior:
Checklist:
enhancement,bug,improvement,new kit,deprecated, orbreaking. See Changelog & Labels for details.milanolabel to show I'm ready for a review.- [ ] TESTS I have added test coverage to my code.minor,major, orpatchlabel for release.inactive RClabel if not an active RC.