[PLAY-2645] Bullet Points in TipTap editor - #6572
Draft
nickamantia wants to merge 3 commits into
Draft
Conversation
nickamantia
added
minor
nidaqg
reviewed
Aug 27, 2026
| { | ||
| icon: "list", | ||
| text: "Bullet List", | ||
| classname: `toolbar_button ${editor.isActive('list') ? 'is-active' : ''}`, |
Contributor
There was a problem hiding this comment.
I think this needs to be editor.isActive('bulletList') to get the active styling.Tiptap uses bulletList, not list.
nidaqg
reviewed
Aug 27, 2026
Comment on lines
+61
to
+67
| classname: `toolbar_button ${editor.isActive('de-indent-list') ? 'is-active' : ''}`, | ||
| onclick: () => editor.chain().focus().liftListItem('listItem').run(), | ||
| }, | ||
| { | ||
| icon: "angle-double-right", | ||
| text: "Indent Bullet", | ||
| classname: `toolbar_button ${editor.isActive('indent-list') ? 'is-active' : ''}`, |
Contributor
There was a problem hiding this comment.
I don't think 'de-indent-list' and 'indent-list' are accurate either, but also I don't think these controls need an active state since you can increase and decrease indents more than once. Might be better to disable them when the command can't run, e.g. using editor.can()
nidaqg
reviewed
Aug 27, 2026
| maxWidth?: string | ||
| TrixEditor?: React.ComponentType<any>, | ||
| trixInstance?: any, | ||
| bulletList?: any, |
Contributor
There was a problem hiding this comment.
this should be boolean so the schemas are accurate as well
nidaqg
added
do not merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do? A clear and concise description with your runway ticket url.
Screenshots: Screenshots to visualize your addition/change
How to test? Steps to confirm the desired behavior:
Checklist:
enhancement,bug,improvement,new kit,deprecated, orbreaking. See Changelog & Labels for details.milanolabel to show I'm ready for a review.minor,major, orpatchlabel for release.inactive RClabel if not an active RC.