[PLAY-3207] Table Kit: Add ColSpan Support + Docs to React and Rails - #6596
Conversation
|
A change to documentation files was detected in your PR. Please visit this link to preview changes: https://portal-staging.powerapp.cloud/docs?filters[kind]=all&filters[user]=all&filters[namespaceFilter]=play-3207-tablekit-colspan-prop |
|
this didn't add anything to the schema or playground, which I'm assuming is because the prop is not on the table itself but on the subcomponent. I think we probably need to do something similar to what we do for the advancedTable for this kit as far as playground overrides is concerned so its knows when props go to a subcomponent. Declare a type in the main file so schema picks it up + have the extra setup in playgrounds overrides.. but I thin k that can be a separate story if you prefer |
Oh good call - I had tested in Playground by editing the Children to include it, but schema did not occur to me. Will look into your suggestion now, thanks! |
|
🎉 Congratulations on creating an Alpha Version! Your Alpha for Ruby Gems is 17.1.0.pre.alpha.PLAY3207tablekitcolspanprop18966 Your Alpha for NPM is 17.1.0-alpha.PLAY3207tablekitcolspanprop18966 |
|
🎉 Congratulations on creating an Alpha Version! Your Alpha for Ruby Gems is 17.1.0.pre.alpha.PLAY3207tablekitcolspanprop18994 Your Alpha for NPM is 17.1.0-alpha.PLAY3207tablekitcolspanprop18994 |
What does this PR do? A clear and concise description with your runway ticket url.
PLAY-3207 adds the colSpan prop to the React Table Header and Table Cell, colspan to the Rails Table Cell, and adds docs for the prop. Rails Table Header already has colspan, and this is a precursor story to creating a Custom Sort embedded in the Header React doc example.
Screenshots: Screenshots to visualize your addition/change

How to test? Steps to confirm the desired behavior:
Playground test: no prop override but can edit children to give Table.Header or Table.Cell a colSpan example code:
Checklist:
enhancement,bug,improvement,new kit,deprecated, orbreaking. See Changelog & Labels for details.milanolabel to show I'm ready for a review.minor,major, orpatchlabel for release.inactive RClabel if not an active RC.