[PLAY-3190] DatePicker: Update TimeSelection Doc - #6623
Open
ElisaShapiro wants to merge 3 commits into
Open
Conversation
ElisaShapiro
added
milano
|
A change to documentation files was detected in your PR. Please visit this link to preview changes: https://portal-staging.powerapp.cloud/docs?filters[kind]=all&filters[user]=all&filters[namespaceFilter]=play-3190-update-datepicker-timeselection-docs |
ElisaShapiro
marked this pull request as ready for review
September 4, 2026 13:23
ElisaShapiro
added
milano
ElisaShapiro
removed
the
milano
nidaqg
approved these changes
Sep 4, 2026
nidaqg
added
the
milano
ElisaShapiro
removed
the
milano
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do? A clear and concise description with your runway ticket url.
PLAY-3190 updates the Date Picker Time Selection React doc + markdown to showcase onClose instead of closeOnSelect. This PR also includes a necessary update to DatePicker doc example rendering which caused the Date Picker dropdown to be obscured inside a self contained wrapper within the doc.
Screenshots: Screenshots to visualize your addition/change
Current prod - wrapper issue (happened for both Rails + React docs):
Updated React doc:
How to test? Steps to confirm the desired behavior:
Checklist:
enhancement,bug,improvement,new kit,deprecated, orbreaking. See Changelog & Labels for details.milanolabel to show I'm ready for a review.- [ ] TESTS I have added test coverage to my code.- [ ] PLAYGROUND I have added and tested Playground metadata and overrides for all kits and props updated in my code.minor,major, orpatchlabel for release.inactive RClabel if not an active RC.