-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch from NextJS -> Vite / plain React for demos #83
Conversation
yjs-react-supabase-text-collab.
Co-authored-by: stevensJourney <[email protected]>
@@ -0,0 +1 @@ | |||
NEXT_PUBLIC_POWERSYNC_URL= |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably need to mention setting this field (and renaming this file) in the Readme?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually getting sync to work would also require setting up a connector. The other two examples (example-vite and example-webpack) also don't have anything for that.
Do you think it's worth expanding all those examples, perhaps with instructions using temporary development tokens?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As newcomer, fake auth connection is good for learning and testing purposes.
IIRC we published those to showcase bundling with these frameworks; I think
showcasing the sync setup is also going to be helpful, but could also be a
future addition. If we implement this later I'd just say we add a note here
explaining how this field would be used, or remove it.
…On Wed, Mar 6, 2024 at 2:05 PM Ralf Kistner ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In demos/example-nextjs/.env.local.template
<#83 (comment)>
:
> @@ -0,0 +1 @@
+NEXT_PUBLIC_POWERSYNC_URL=
Actually getting sync to work would also require setting up a connector.
The other two examples (example-vite and example-webpack) also don't have
anything for that.
Do you think it's worth expanding all those examples, perhaps with
instructions using temporary development tokens?
—
Reply to this email directly, view it on GitHub
<#83 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABYH5IFFYLF7TCI56ZGPHYLYW4BB5AVCNFSM6AAAAABD6D6DGSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSMJZGU3DCOBWGA>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
@benitav I added minimal notes on configuring the example with a development token. |
37fc884
to
f8c211d
Compare
NextJS's server-side rendering mostly just conflicts with our local-first approach, with multiple workarounds required to make it functional. This attempts to simplify the supabase-todolist demo by not using NextJS.
The app is mostly unchanged. The main changes are:
In the future, it will also allow:
This similarly migrates the Yjs demo, adds a new "example-nextjs" to still have the basic boilerplate for NextJS available.
This also fixes some null-check issues, giving better feedback when credentials are not provided.
TODO:
react-supabase-todolist
.