[WIP] Optimize incremental sync: Phase 2 - cache parameter queries #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rkistner
force-pushed
the
optimize-bucket-lookups-2
branch
from
8aea0ab to
3e257fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #197.
This detects whether some row changed that could affect parameter query on each checkpoint. The net result is that we can avoid refreshing parameter queries in many cases, reducing load on the database.
This does not optimize re-checking individual buckets for changes yet. We do cache those results, so as long as the number of buckets are not too large that should still be efficient enough.