Skip to content

Commit

Permalink
Use regular http package on the web
Browse files Browse the repository at this point in the history
That package uses fetch since version 1.3.0, so there's no need for
another dependency on the web.
  • Loading branch information
simolus3 committed Feb 12, 2025
1 parent c0d44cb commit 6f35a63
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 7 deletions.
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import 'dart:async';
import 'package:meta/meta.dart';
import 'package:fetch_client/fetch_client.dart';
import 'package:http/http.dart';
import 'package:logging/logging.dart';
import 'package:powersync_core/src/abort_controller.dart';
import 'package:powersync_core/src/bucket_storage.dart';
Expand Down Expand Up @@ -166,7 +166,7 @@ class PowerSyncDatabaseImpl
uploadCrud: () => connector.uploadData(this),
crudUpdateTriggerStream: crudStream,
retryDelay: Duration(seconds: 3),
client: FetchClient(mode: RequestMode.cors),
client: Client(),
syncParameters: params,
// Only allows 1 sync implementation to run at a time per database
// This should be global (across tabs) when using Navigator locks.
Expand Down
6 changes: 3 additions & 3 deletions packages/powersync_core/lib/src/web/sync_worker.dart
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,14 @@ import 'dart:convert';
import 'dart:js_interop';

import 'package:async/async.dart';
import 'package:fetch_client/fetch_client.dart';
import 'package:http/http.dart';
import 'package:logging/logging.dart';
import 'package:powersync_core/powersync_core.dart';
import 'package:powersync_core/sqlite_async.dart';
import 'package:powersync_core/src/database/powersync_db_mixin.dart';
import 'package:powersync_core/src/streaming_sync.dart';
import 'package:sqlite_async/web.dart';
import 'package:web/web.dart' hide RequestMode;
import 'package:web/web.dart' hide Client;

import 'sync_worker_protocol.dart';
import 'web_bucket_storage.dart';
Expand Down Expand Up @@ -265,7 +265,7 @@ class _SyncRunner {
uploadCrud: client.channel.uploadCrud,
crudUpdateTriggerStream: crudStream,
retryDelay: Duration(seconds: 3),
client: FetchClient(mode: RequestMode.cors),
client: Client(),
identifier: identifier,
syncParameters: syncParams);
sync!.statusStream.listen((event) {
Expand Down
3 changes: 1 addition & 2 deletions packages/powersync_core/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,11 @@ dependencies:
sqlite3_web: ^0.3.0
universal_io: ^2.0.0
meta: ^1.0.0
http: ^1.1.0
http: ^1.3.0
uuid: ^4.2.0
async: ^2.10.0
logging: ^1.1.1
collection: ^1.17.0
fetch_client: ^1.1.2
web: ^1.0.0

# Only used internally to download WASM / worker files.
Expand Down

0 comments on commit 6f35a63

Please sign in to comment.