Avoid emitting duplicate sync status events #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkistner
reviewed
Jan 15, 2025
stevensJourney
previously approved these changes
Jan 16, 2025
rkistner
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We generally have mechanisms in place that try to prevent duplicate sync state events being emitted by
statusStream. In the powersync mixin however, we apply a transformation on incoming events to sethasSynced(a field that is not set on the events that method receives). This means that incoming events only differing due tohasSyncedbeing absent effectively cause us to re-emit the last snapshot.I've also added a call to close the stream when the database is closed (generally useful to free up listeners, and also makes testing this easier).
Closes #224