Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React native 0.76 compatibility #59

Merged
merged 10 commits into from
Nov 19, 2024
Merged

Conversation

mugikhan
Copy link
Contributor

@mugikhan mugikhan commented Nov 5, 2024

Description

This PR was originally intended to only upgrade the android minSdkVersion to 24 for react-native v0.76 and Expo 52 beta compatibility. This leads to some more changes required to make the library work with RN v0.76. There is now a merged libreactnative.so file which is used for smaller package sizes and improved performance see this discussion.
This meant updating the cMakeLists to use the new merged dynamic library when RN v0.76 or greater is detected.

TODO

  • Update example test app to use Expo 52 and RN 0.76.

@mugikhan mugikhan marked this pull request as ready for review November 18, 2024 16:30
Copy link
Collaborator

@stevensJourney stevensJourney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@mugikhan mugikhan merged commit 1245e82 into main Nov 19, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants