Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix web database not respecting lock timeouts #88

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix web database not respecting lock timeouts #88

wants to merge 1 commit into from

Conversation

simolus3
Copy link
Contributor

The readLock and writeLock APIs have a lockTimeout parameter to not wait on locks longer than intended. The WebDatabase implementation did not forward these arguments properly, this fixes that.

I've also removed an unused field on MutexImpl on the web and simplified the check for navigator.locks a bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevensJourney stevensJourney stevensJourney approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simolus3 @stevensJourney