[Fix] Table Change Notifications Memory #17
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This fixes an issue where table change notifications would sometimes report "garbage" changed table names.
For example see this snapshot of a batched notification:
The table names are extracted from the heap via the pointer provided by SQLite. We convert the C pointer to a JavaScript string in the update notification handler.
SQLite3 executes the update hook synchronously. We execute our update notification callbacks in a
setTimeout
to avoid blocking SQLite3. This causes issues when using the provided pointer since the data could have been freed after SQLite's synchronous execution.This changes the order of operations to first fetch the table name strings synchronously then fire the downstream callbacks asynchronously.