-
Notifications
You must be signed in to change notification settings - Fork 1
move export case to network conversion server #90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Etienne LESOT <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove ExportCaseInfos (not used)
Remove:
public static CaseException createCopyZipContentError(UUID uuid, Exception e) {
return new CaseException(Type.ZIP_FILE_PROCESS, "Error copying zip content file: " + uuid, e);
}
public static CaseException createUnsupportedFormat(String format) {
return new CaseException(Type.UNSUPPORTED_FORMAT, "The format: " + format + " is unsupported");
}
(not used)
and
ZIP_FILE_PROCESS,
UNSUPPORTED_FORMAT
that are not used
See: c38a316#diff-15b959878419fa937da7a7fb04ad34aed18cdd30c0f437dbccb30117bc0a0537
do I remove TEMP_FILE_PROCESS too ? @antoinebhs |
Signed-off-by: Etienne LESOT <[email protected]>
…rver Signed-off-by: Etienne LESOT <[email protected]>
If not used, yes |
Signed-off-by: Etienne LESOT <[email protected]>
src/test/java/com/powsybl/caseserver/service/AbstractCaseControllerTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/powsybl/caseserver/service/AbstractCaseControllerTest.java
Show resolved
Hide resolved
src/test/java/com/powsybl/caseserver/service/AbstractCaseControllerTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Etienne LESOT <[email protected]>
src/test/java/com/powsybl/caseserver/service/AbstractCaseControllerTest.java
Show resolved
Hide resolved
Signed-off-by: Etienne LESOT <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code OK
|
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
Other information: