Skip to content

move export case to network conversion server #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 28, 2025

Conversation

EtienneLt
Copy link
Collaborator

@EtienneLt EtienneLt commented Apr 17, 2025

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • A PR or issue has been opened in all impacted repositories (if any)

Does this PR already have an issue describing the problem?
no

What kind of change does this PR introduce?
remove code as it is moved to powsybl network conversion server

What is the current behavior?

What is the new behavior (if this is a feature change)?
powsybl case srver does not convert case any more

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)
do not use export endpoint anymore and use convert endpoint in powsybl conversion server

Other information:
it is linked to these pr in network conversion server powsybl/powsybl-network-conversion-server#185

@EtienneLt EtienneLt self-assigned this Apr 17, 2025
Copy link
Collaborator

@antoinebhs antoinebhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove ExportCaseInfos (not used)
Remove:

    public static CaseException createCopyZipContentError(UUID uuid, Exception e) {
        return new CaseException(Type.ZIP_FILE_PROCESS, "Error copying zip content file: " + uuid, e);
    }

    public static CaseException createUnsupportedFormat(String format) {
        return new CaseException(Type.UNSUPPORTED_FORMAT, "The format: " + format + " is unsupported");
    }

(not used)
and

        ZIP_FILE_PROCESS,
        UNSUPPORTED_FORMAT

that are not used
See: c38a316#diff-15b959878419fa937da7a7fb04ad34aed18cdd30c0f437dbccb30117bc0a0537

@EtienneLt
Copy link
Collaborator Author

do I remove TEMP_FILE_PROCESS too ? @antoinebhs

@antoinebhs
Copy link
Collaborator

do I remove TEMP_FILE_PROCESS too ? @antoinebhs

If not used, yes

Signed-off-by: Etienne LESOT <[email protected]>
Signed-off-by: Etienne LESOT <[email protected]>
Signed-off-by: Etienne LESOT <[email protected]>
Copy link
Collaborator

@antoinebhs antoinebhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code OK

Copy link

@antoinebhs antoinebhs merged commit 9dbd890 into main Apr 28, 2025
5 checks passed
@antoinebhs antoinebhs deleted the remove-export-case-as-added-in-conversion-server branch April 28, 2025 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants