[WIP] First try on CGMES Equipment network import #1965

miovd · 2022-02-04T14:15:08Z

Please check if the PR fulfills these requirements (please use '[x]' to check the checkboxes, or submit the PR and then click the checkboxes)

The commit message follows our guidelines
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem ? If so, link to this issue using '#XXX' and skip the rest
No

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature

What is the current behavior? (You can also link to an open issue here)
CGMES imported networks are always at STEADY_STATE_HYPOTHESIS validation level

What is the new behavior (if this is a feature change)?
CGMES imported networks are at EQUIPMENT level if they only contains equipment-related profiles and boundaries (optional). The current PR only regards flows and generators' regulation. Other PRs are to follow.

Does this PR introduce a breaking change or deprecate an API? If yes, check the following:

The Breaking Change or Deprecated label has been added
The migration guide has been updated in the github wiki (What changes might users need to make in their application due to this PR?)

…detection + loads with undefined p0/q0 Signed-off-by: VEDELAGO MIORA <[email protected]>

Signed-off-by: VEDELAGO MIORA <[email protected]>

...conversion/src/main/java/com/powsybl/cgmes/conversion/elements/EnergyConsumerConversion.java

annetill · 2022-02-10T09:52:28Z

...conversion/src/main/java/com/powsybl/cgmes/conversion/elements/EnergyConsumerConversion.java

+            if (context.cgmes().hasOnlyEquipmentProfile()) {
+                return Double.NaN;
+            }
+            return 0.0;


What is the aim of this 0.0 value ?

It is for default values when there is several profiles (not only EQ and boundaries) in the CGMES file

I think we could avoid checking if the input data contains only EQ to use a default value of NaN.

If we let NaN always as the default value we will be able to identify/report situations where some loads defined in the model have not been properly initialized in the SSH (and the code would be simpler).

I realize this is a change over the previous behaviour, but I think that following our current ability of using validation levels, it would be worth it. It would report the Network as not yet containing a complete set of steady state hypothesis.

What do you think?

Your proposal is the cleanest one for sure, but not maybe the most realistic: many IGM will have a validation level at EQ, whereas we really want to run a load flow on it after import. I can imagine that in the TYNDP files, we are far from a SSH validation level... what do you think ?

zamarrenolm · 2022-02-11T14:08:16Z

I think we could also adjust the p0 and q0 functions in AbstractConductingEquipment to return NaN if no explicit value is given for p, q, instead of returning 0. Not only in the EnergyConsumerConversion.

Signed-off-by: VEDELAGO MIORA <[email protected]>

… + correction Signed-off-by: VEDELAGO MIORA <[email protected]>

Signed-off-by: VEDELAGO MIORA <[email protected]>

miovd · 2022-03-15T15:09:59Z

This PR is to be completed with other attributes but I'm letting it in its current state for us to agree on the design

… it has to be set by the user Signed-off-by: VEDELAGO MIORA <[email protected]>

sonarqubecloud · 2022-03-15T15:54:06Z

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities
0 Security Hotspots
3 Code Smells

70.6% Coverage
0.0% Duplication

annetill · 2022-03-21T13:54:03Z

...n/src/main/java/com/powsybl/cgmes/conversion/FixedRegulatingControlMappingForGenerators.java

+        double targetV = control.targetValue;
+        Terminal terminal = parent.findRegulatingTerminal(control.cgmesTerminal);
+        if (voltageRegulatorOn && terminal == null) { // If regulating terminal null, regulation is made local
+            context.fixed(controlId, () -> "Unmapped regulating terminal and impossible to find an equivalent terminal. Regulation is made local.");


When we have a regulation on and a null terminal, I think that the good fix is to discard the regulation. Maybe in an other PR.

annetill · 2022-03-21T13:58:24Z

...n/src/main/java/com/powsybl/cgmes/conversion/FixedRegulatingControlMappingForGenerators.java

+            targetV = terminal.getVoltageLevel().getNominalV();
+        }
+        if (voltageRegulatorOn && (control.targetValue <= 0.0 || Double.isNaN(control.targetValue))) {
+            targetV = terminal.getVoltageLevel().getNominalV();


Here too: the good fix should be to set voltageRegulatorOn to false. Maybe in an other PR.

annetill · 2022-03-21T14:01:00Z

cgmes/cgmes-conversion/src/main/java/com/powsybl/cgmes/conversion/Context.java

@@ -48,13 +49,21 @@ public Context(CgmesModel cgmes, Config config, Network network) {
        // based on existing node-breaker info
        nodeBreaker = cgmes.isNodeBreaker() && config.useNodeBreaker();

+        if (config.getMinimumValidationLevel() == ValidationLevel.EQUIPMENT) {
+            flowsDefaultValue = Double.NaN;


Maybe add as comment that it means active and reactive power default value. The fixSsh could be something more explicit as forceValidationLevelToSteadyStateHypothesis.

annetill · 2022-03-21T14:09:00Z

...src/main/java/com/powsybl/cgmes/conversion/UnfixedRegulatingControlMappingForGenerators.java

+        // Null terminal if it has not been defined in CGMES file
+        Terminal terminal = parent.findRegulatingTerminal(control.cgmesTerminal);
+        if (terminal == null) {
+            context.invalid(() -> controlId, () -> "Unmapped regulating terminal.");


Unmapped really? But here it will be forced as local terminal, no?

miovd added 2 commits February 4, 2022 15:15

First try on importing CGMES networks at EQUIPMENT validation level: …

8991b2f

…detection + loads with undefined p0/q0 Signed-off-by: VEDELAGO MIORA <[email protected]>

Add tests

368b592

Signed-off-by: VEDELAGO MIORA <[email protected]>

miovd force-pushed the first_eq_cgmes_import branch from dbf4d23 to 368b592 Compare February 4, 2022 14:15

miovd changed the title ~~First try on CGMES Equipment network import~~ [WIP] First try on CGMES Equipment network import Feb 4, 2022

miovd added 3 commits February 4, 2022 15:44

Fix code smells

e9a872b

Signed-off-by: VEDELAGO MIORA <[email protected]>

Fix code smell

b09646a

Signed-off-by: VEDELAGO MIORA <[email protected]>

Add test

6869503

Signed-off-by: VEDELAGO MIORA <[email protected]>

miovd changed the title ~~[WIP] First try on CGMES Equipment network import~~ First try on CGMES Equipment network import Feb 9, 2022

miovd requested review from zamarrenolm, marcosmc and annetill February 9, 2022 13:50

miovd added CGMES PR: waiting-for-review Breaking Change API is broken labels Feb 9, 2022

annetill reviewed Feb 10, 2022

View reviewed changes

...conversion/src/main/java/com/powsybl/cgmes/conversion/elements/EnergyConsumerConversion.java Outdated Show resolved Hide resolved

annetill reviewed Feb 10, 2022

View reviewed changes

zamarrenolm added 2 commits February 11, 2022 12:32

Merge branch 'main' into first_eq_cgmes_import

8177dc6

Merge branch 'main' into first_eq_cgmes_import

5649f1b

miovd changed the title ~~First try on CGMES Equipment network import~~ [WIP] First try on CGMES Equipment network import Feb 14, 2022

miovd added 8 commits March 8, 2022 13:12

Change mechanism: introduce defaultValue in Context

e66ed93

Signed-off-by: VEDELAGO MIORA <[email protected]>

Add parameter set by user (optional)

cea3c41

Signed-off-by: VEDELAGO MIORA <[email protected]>

Revert creation of useless method

b03a801

Signed-off-by: VEDELAGO MIORA <[email protected]>

Renaming

901e7c4

Signed-off-by: VEDELAGO MIORA <[email protected]>

Add test

83ddec9

Signed-off-by: VEDELAGO MIORA <[email protected]>

First try to import generators regulation with lower validation level…

811c9ae

… + correction Signed-off-by: VEDELAGO MIORA <[email protected]>

Small fix in logging

a3dfdb7

Signed-off-by: VEDELAGO MIORA <[email protected]>

Merge branch 'main' into first_eq_cgmes_import

4811879

miovd changed the title ~~[WIP] First try on CGMES Equipment network import~~ First try on CGMES Equipment network import Mar 9, 2022

Small correction to keep behavior

d5c4dd1

Signed-off-by: VEDELAGO MIORA <[email protected]>

No implicitly set of minimum validation level according to the files:…

7792f67

… it has to be set by the user Signed-off-by: VEDELAGO MIORA <[email protected]>

annetill reviewed Mar 21, 2022

View reviewed changes

miovd added the PR: conflict-with-main label Mar 30, 2022

miovd changed the title ~~First try on CGMES Equipment network import~~ [WIP] First try on CGMES Equipment network import Mar 30, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] First try on CGMES Equipment network import #1965

[WIP] First try on CGMES Equipment network import #1965

miovd commented Feb 4, 2022 •

edited

Loading

annetill Feb 10, 2022

miovd Feb 10, 2022

zamarrenolm Feb 11, 2022

annetill Feb 11, 2022

zamarrenolm commented Feb 11, 2022

miovd commented Mar 15, 2022

sonarqubecloud bot commented Mar 15, 2022

annetill Mar 21, 2022

annetill Mar 21, 2022

annetill Mar 21, 2022

annetill Mar 21, 2022

[WIP] First try on CGMES Equipment network import #1965

Are you sure you want to change the base?

[WIP] First try on CGMES Equipment network import #1965

Conversation

miovd commented Feb 4, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zamarrenolm commented Feb 11, 2022

miovd commented Mar 15, 2022

sonarqubecloud bot commented Mar 15, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

miovd commented Feb 4, 2022 •

edited

Loading