[WIP] Deprecate creation of new LoadingLimits from Branch and FlowsLimitsHo… #3340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lder Signed-off-by: Giovanni Ferrari <[email protected]>
|
There are 2 test failing because replacing the call "line.newCurrentLimits()" with "line.getOrCreateSelectedOperationalLimitsGroup1().newCurrentLimits()" the SelectedOperationalLimitsGroup is modified even if the Adder validation is not called or fails: LineTest>AbstractLineTest.dontChangeDefaultOperationalLimitsGroupIfAdderValidationFails:742 expected: but was: |
So-Fras
added
Breaking Change
alicecaron
reviewed
Apr 17, 2025
| /** | ||
| * <p>Get the {@link OperationalLimitsGroup} corresponding to the given ID or create a new one if it does not exists. | ||
| * Set the {@link OperationalLimitsGroup} as the selected one on side 1.</p> | ||
| * @param id an ID of {@link OperationalLimitsGroup} |
There was a problem hiding this comment.
Suggested change
| * @param id an ID of {@link OperationalLimitsGroup} | |
| * @param limitsGroupId an ID of {@link OperationalLimitsGroup} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…lder
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
#3212
What kind of change does this PR introduce?
Does this PR introduce a new Powsybl Action implying to be implemented in simulators or pypowsybl?
What is the current behavior?
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
Other information: