-
Notifications
You must be signed in to change notification settings - Fork 45
Support of all UTF-16 characters in IdWithWildcardsNetworkElementIdentifier
#3342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
olperr1
wants to merge
8
commits into
main
Choose a base branch
from
choosable_wildcard_in_identifier
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: CARON Alice <[email protected]>
Signed-off-by: CARON Alice <[email protected]>
Signed-off-by: Olivier Perrin <[email protected]>
…fiers Signed-off-by: Olivier Perrin <[email protected]>
Signed-off-by: Olivier Perrin <[email protected]>
IdWithWildcardsNetworkElementIdentifier
IdWithWildcardsNetworkElementIdentifier
Signed-off-by: Olivier Perrin <[email protected]>
Signed-off-by: Olivier Perrin <[email protected]>
Signed-off-by: Olivier Perrin <[email protected]>
|
alicecaron
approved these changes
Mar 4, 2025
IdWithWildcardsNetworkElementIdentifier
IdWithWildcardsNetworkElementIdentifier
IdWithWildcardsNetworkElementIdentifier
IdWithWildcardsNetworkElementIdentifier
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Feature
Does this PR introduce a new Powsybl Action implying to be implemented in simulators or pypowsybl?
What is the current behavior?
IdWithWildcardsNetworkElementIdentifier
pattern were from A to Z (capitalized or not), the digits, '_', '.' or '-'.What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
IdWithWildcardsNetworkElementIdentifier
now contains awildcard
attribute. When reading a JSON without this attribute, the default wildcard (?
) is used.IdWithWildcardsNetworkElementIdentifier
) are potentially impacted. Their serialization version numbers were increased:ActionList
1.1
1.2
IdentifierContingencyList
1.2
1.3
ListOfContingencyLists
1.0
1.1
Also, this change of serialization versions can have an impact on your unit tests (if you use a JSON serialized object as a reference).
Other information: