Partly clean ReportNode use in ValidationUtil #3353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flo-dup
force-pushed
the
validation_util_report_node
branch
from
e9ad2e9 to
412f277
Compare
|
flo-dup
force-pushed
the
integration/report_node_i18n
branch
from
70c192d to
a6957c2
Compare
Signed-off-by: Florian Dupuy <[email protected]> Signed-off-by: CARON Alice <[email protected]> Conflicts: iidm/iidm-api/src/main/java/com/powsybl/iidm/network/util/NetworkReports.java iidm/iidm-modification/src/main/java/com/powsybl/iidm/modification/util/ModificationReports.java ucte/ucte-network/src/main/java/com/powsybl/ucte/network/util/UcteReports.java
alicecaron
force-pushed
the
validation_util_report_node
branch
from
412f277 to
a9787e0
Compare
alicecaron
reviewed
Apr 2, 2025
| core.iidm.network.MoveCommonAlias = Alias ${alias} found in dangling lines ${danglingLineId1} and ${danglingLineId2} is moved to their merged line. | ||
| core.iidm.network.PropertyOnlyOnOneSide = Inconsistencies of property ${propertyName} between both sides (${danglingLineId1) on side 1 and ${danglingLineId2} on side2) of merged line. Side ${side} has no value. Value on other side is kept. | ||
| core.iidm.network.ptcPhaseRegulationFixedMode = phase regulation cannot be on if mode is FIXED |
There was a problem hiding this comment.
Start the templates with a first upper case character?
| } | ||
|
|
||
| public static void targetDeadbandUndefinedValue(String validableType, ReportNode reportNode) { | ||
| String key = switch (validableType) { |
There was a problem hiding this comment.
Instead of manipulating a String can we create en enum to handle all the possibilities? For instance:
public enum ValidableType {
SHUNT_COMPENSATOR,
PHASE_TAP_CHANGER,
RATIO_TAP_CHANGER
}
But there are more than 3 ValidableType so maybe we need to list them all
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
The ReportNode is used in ValidationUtil with generated keys (Validable::getMessageHeader) for message template
What is the new behavior (if this is a feature change)?
The ReportNode is used in ValidationUtil with fixed keys for a given template
Does this PR introduce a breaking change or deprecate an API?
Other information:
⚠️ The message lacks the correct information which is expected by the user: getMessageHeader usually gives the equipmentType and the equipment id. But this was already the case before, as this information was used as a template key, hence never displayed to the user. A PR will follow later to fix this, but this requires breaking changes.