Fix ReportNode use in ValidationUtil #3353
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flo-dup
force-pushed
the
validation_util_report_node
branch
from
e9ad2e9 to
412f277
Compare
|
flo-dup
force-pushed
the
integration/report_node_i18n
branch
from
70c192d to
a6957c2
Compare
alicecaron
force-pushed
the
validation_util_report_node
branch
from
412f277 to
a9787e0
Compare
alicecaron
reviewed
Apr 2, 2025
commons/src/main/resources/com/powsybl/commons/reports.properties
Outdated
Show resolved
Hide resolved
iidm/iidm-api/src/main/java/com/powsybl/iidm/network/util/NetworkReports.java
Show resolved
Hide resolved
Signed-off-by: Florian Dupuy <[email protected]> Signed-off-by: CARON Alice <[email protected]>
Signed-off-by: Florian Dupuy <[email protected]>
Signed-off-by: Florian Dupuy <[email protected]>
flo-dup
force-pushed
the
validation_util_report_node
branch
from
a9787e0 to
58d79a5
Compare
olperr1
requested changes
Jun 27, 2025
iidm/iidm-api/src/main/java/com/powsybl/iidm/network/ValidationUtil.java
Outdated
Show resolved
Hide resolved
github-project-automation
bot
moved this from In Progress
to Waiting for review
in Release 06/2025
Signed-off-by: Florian Dupuy <[email protected]>
Signed-off-by: Florian Dupuy <[email protected]>
Signed-off-by: Florian Dupuy <[email protected]>
Signed-off-by: Florian Dupuy <[email protected]>
Signed-off-by: Florian Dupuy <[email protected]>
Signed-off-by: Florian Dupuy <[email protected]>
flo-dup
changed the title
Signed-off-by: Florian Dupuy <[email protected]>
olperr1
approved these changes
Jul 1, 2025
github-project-automation
bot
moved this from Waiting for review
to Approved
in Release 06/2025
8 tasks
alicecaron
approved these changes
Jul 1, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
The ReportNode is used in ValidationUtil
Validable::getMessageTemplatewas used as a template key, hence never displayed to the user.What is the new behavior (if this is a feature change)?
The ReportNode is used in ValidationUtil
Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
NetworkReports.parentHasBothRatioAndPhaseTapChanger(ReportNode reportNode, String parentMessage)was replaced byNetworkReports.transformerHasBothRatioAndPhaseTapChanger(ReportNode reportNode, String id).NetworkReports.parentHasDuplicatePointForActivePower(ReportNode reportNode, String ownerMessage, Double p)was replaced byNetworkReports.parentHasDuplicatePointForActivePower(ReportNode reportNode, String id, Double p).MessageHeaderinstead of aStringforgetMessageHeadermethod in the classes implementingValidable.