Add method to get the terminal of a 3-winding transformer from one of its voltage level ids #3355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Etienne LESOT <[email protected]>
Signed-off-by: Etienne LESOT <[email protected]>
alicecaron
approved these changes
Apr 2, 2025
|
olperr1
changed the title
olperr1
requested changes
Apr 15, 2025
| boolean side2 = getLeg2().getTerminal().getVoltageLevel().getId().equals(voltageLevelId); | ||
| boolean side3 = getLeg3().getTerminal().getVoltageLevel().getId().equals(voltageLevelId); | ||
| if (side1 && side2 && side3) { | ||
| throw new PowsyblException("the three terminals are connected to the same voltage level " + voltageLevelId); |
There was a problem hiding this comment.
Suggested change
| throw new PowsyblException("the three terminals are connected to the same voltage level " + voltageLevelId); | |
| throw new PowsyblException("The three terminals are connected to the same voltage level " + voltageLevelId); |
| if (side1 && side2 && side3) { | ||
| throw new PowsyblException("the three terminals are connected to the same voltage level " + voltageLevelId); | ||
| } else if (side1 && side2 || side3 && side1 || side2 && side3) { | ||
| throw new PowsyblException("two of the three terminals are connected to the same voltage level " + voltageLevelId); |
There was a problem hiding this comment.
Suggested change
| throw new PowsyblException("two of the three terminals are connected to the same voltage level " + voltageLevelId); | |
| throw new PowsyblException("Two of the three terminals are connected to the same voltage level " + voltageLevelId); |
| .add() | ||
| .add(); | ||
| message = assertThrows(PowsyblException.class, () -> transformer4.getTerminal("vl1")).getMessage(); | ||
| assertEquals("the three terminals are connected to the same voltage level vl1", message); |
There was a problem hiding this comment.
Suggested change
| assertEquals("the three terminals are connected to the same voltage level vl1", message); | |
| assertEquals("The three terminals are connected to the same voltage level vl1", message); |
| assertEquals(transformer.getTerminal("vl1").getBusBreakerView().getConnectableBus(), | ||
| transformer.getLeg1().getTerminal().getBusBreakerView().getConnectableBus()); | ||
| String message = assertThrows(PowsyblException.class, () -> transformer.getTerminal("vl2")).getMessage(); | ||
| assertEquals("two of the three terminals are connected to the same voltage level vl2", message); |
There was a problem hiding this comment.
Suggested change
| assertEquals("two of the three terminals are connected to the same voltage level vl2", message); | |
| assertEquals("Two of the three terminals are connected to the same voltage level vl2", message); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Feature
What is the new behavior (if this is a feature change)?
Enable to get the terminal of a leg basing on only the voltageLevel's Id
Does this PR introduce a breaking change or deprecate an API?
Migration steps:
Custom IIDM implementation maintainers should implement the following method in their
ThreeWindingsTransformer's implementations: