Add method to get the terminal of a 3-winding transformer from one of its voltage level ids #3355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Etienne LESOT <[email protected]>
Signed-off-by: Etienne LESOT <[email protected]>
alicecaron
previously approved these changes
Apr 2, 2025
github-project-automation
bot
moved this from Waiting for review
to Approved
in Release 06/2025
|
olperr1
changed the title
olperr1
requested changes
Apr 15, 2025
iidm/iidm-impl/src/main/java/com/powsybl/iidm/network/impl/ThreeWindingsTransformerImpl.java
Outdated
Show resolved
Hide resolved
iidm/iidm-impl/src/main/java/com/powsybl/iidm/network/impl/ThreeWindingsTransformerImpl.java
Outdated
Show resolved
Hide resolved
...idm-tck/src/test/java/com/powsybl/iidm/network/tck/AbstractThreeWindingsTransformerTest.java
Outdated
Show resolved
Hide resolved
...idm-tck/src/test/java/com/powsybl/iidm/network/tck/AbstractThreeWindingsTransformerTest.java
Outdated
Show resolved
Hide resolved
github-project-automation
bot
moved this from Approved
to Waiting for review
in Release 06/2025
rolnico
requested changes
May 28, 2025
Signed-off-by: Etienne LESOT <[email protected]>
Signed-off-by: Olivier Perrin <[email protected]>
olperr1
force-pushed
the
add-get-terminal-vl-for-3wt
branch
from
a20125d to
876ca36
Compare
The history is clean, now. |
olperr1
requested changes
Jun 3, 2025
iidm/iidm-impl/src/main/java/com/powsybl/iidm/network/impl/ThreeWindingsTransformerImpl.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Etienne LESOT <[email protected]>
olperr1
requested changes
Jun 5, 2025
iidm/iidm-impl/src/main/java/com/powsybl/iidm/network/impl/ThreeWindingsTransformerImpl.java
Outdated
Show resolved
Hide resolved
iidm/iidm-impl/src/main/java/com/powsybl/iidm/network/impl/ThreeWindingsTransformerImpl.java
Outdated
Show resolved
Hide resolved
rolnico
previously approved these changes
Jun 5, 2025
Signed-off-by: Etienne LESOT <[email protected]>
olperr1
requested changes
Jun 5, 2025
iidm/iidm-impl/src/main/java/com/powsybl/iidm/network/impl/ThreeWindingsTransformerImpl.java
Outdated
Show resolved
Hide resolved
iidm/iidm-impl/src/main/java/com/powsybl/iidm/network/impl/ThreeWindingsTransformerImpl.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Etienne LESOT <[email protected]>
olperr1
approved these changes
Jun 5, 2025
github-project-automation
bot
moved this from Waiting for review
to Approved
in Release 06/2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Feature
What is the new behavior (if this is a feature change)?
Enable to get the terminal of a leg basing on only the voltageLevel's Id
Does this PR introduce a breaking change or deprecate an API?
Migration steps:
Custom IIDM implementation maintainers should implement the following method in their
ThreeWindingsTransformer's implementations: