Rework nodes mapping to allow export of isolated nodes #3372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Romain Courtier <[email protected]>
rcourtier
force-pushed
the
export_isolated_nodes
branch
from
95ddb6a to
2c2a508
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No.
What kind of change does this PR introduce?
Fix.
What is the current behavior?
The node of an isolated IIDM equipment (a connectable not linked to any other element either through switch or internal connection) isn't exported to CGMES. This leads to a cardinality issue in the CGMES EQ file where the terminal of the isolated equipment doesn't have a ConnectivityNode association.
What is the new behavior (if this is a feature change)?
The node of an isolated IIDM equipment is exported to CGMES.
Does this PR introduce a breaking change or deprecate an API?
Other information:
Nodes are now exported in order of their number. This shall ensure that nodes are exported in the same order they have been imported and thus in the case of a round-trip import/export the numbers should be the same.