Drop support for CIM14

[quinarygio]

Please check if the PR fulfills these requirements

• The commit message follows our guidelines
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features) --> The documentation mentions only version 2.4.15 (CIM 16) and 3.0 (CIM 100). CIM 14 was not mentioned.
• A PR or issue has been opened in all impacted repositories (if any)

Does this PR already have an issue describing the problem?

Fixes #3290

Does this PR introduce a breaking change or deprecate an API?

• Yes
• No

If yes, please check if the following requirements are fulfilled

• The Breaking Change or Deprecated label has been added
• The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

• CIM 14 CGMES files are not supported anymore. Please use CIM16 (2.4.15) or CIM100 (3.0) files.
• As a direct consequence, the followings were removed:
  • CgmesModel.CIM_14_NAMESPACE,
  • CgmesModel.CIM_14,
  • CgmesOnDataSource.existsCim14() : now it would have always returned false,
  • CgmesModel.Cim.hasProfiles(): now it would have always returned true.
• The CgmesModel interface was also modified. The method modelProfiles is no longer a default method, meaning that you have now to implement it if you designed your own implementation of the interface.
• The public constant CIM_LIST from the CgmesNamespace class has gone from List.of(CIM_14, CIM_16, CIM_100) to List.of(CIM_16, CIM_100)
• Deleted CIM14 network files are available in previous releases ( $vX.Y.Z \leq v6.7.0$) if needed.

[So-Fras]

Thanks for your work! I left a few comments and some questions for @rcourtier :)

[So-Fras]

Thanks for the changes, I left new comments too (things I missed the first time).

There are also 2 test resources files that you can delete: empty_cim14_EQ.xml and empty_cim14_SV.xml.

There are also tests where "cim14" still appears, namely:

• CgmesNamingStrategyTest
• EquipmentExportTest
• EquipementExportTest
• CgmesOnDataSourceTest

(the cgmes-conversion module test resources cim14 folder should be deleted too)

In the OperationalLimitConversion class, there is a comment mentioning CIM14 (line 52).

The file invalidContent_EQ in the cgmes-model-test still mentions "cim14" as well.

[quinarygio]

Thanks for the changes, I left new comments too (things I missed the first time).

There are also 2 test resources files that you can delete: empty_cim14_EQ.xml and empty_cim14_SV.xml.

There are also tests where "cim14" still appears, namely:

• CgmesNamingStrategyTest
• EquipmentExportTest
• EquipementExportTest
• CgmesOnDataSourceTest

(the cgmes-conversion module test resources cim14 folder should be deleted too)

In the OperationalLimitConversion class, there is a comment mentioning CIM14 (line 52).

The file invalidContent_EQ in the cgmes-model-test still mentions "cim14" as well.

CgmesNamingStrategyTest and EquipmentExportTest use files nordic32.xiidm and ieee14.xiidm from cim14 folder, but the files are in XIIDM format. What should I do ?

CgmesOnDataSourceTest.testExists() test is using empty_cim14_EQ.xml to test that CIM14 is not supported

OperationalLimitConversion what should I do with this check ?

 if (limitSubclass == null) {
                // Support for CIM14, all limits are assumed to be current
                limitSubclass = CgmesNames.CURRENT_LIMIT;
 }

[rcourtier]

In CgmesNamespace class, can you please remove the hasProfiles() from the Cim interface and AbstractCim implementation?
It was intended to highlight the difference between CIM14 which has no profiles and CIM16 and above which have profiles. Now the method always return true, so it has lost its interest.

[rcourtier]

CgmesNamingStrategyTest and EquipmentExportTest use files nordic32.xiidm and ieee14.xiidm from cim14 folder, but the files are in XIIDM format. What should I do ?

You can remove the files (the whole folder cim14 actually) and the corresponding tests in CgmesNamingStrategyTest and EquipmentExportTest

CgmesOnDataSourceTest.testExists() test is using empty_cim14_EQ.xml to test that CIM14 is not supported

You can keep empty_cim14_EQ.xml as you said to highlight the fact that CIM14 is not supported.

OperationalLimitConversion what should I do with this check ?

 if (limitSubclass == null) {
                // Support for CIM14, all limits are assumed to be current
                limitSubclass = CgmesNames.CURRENT_LIMIT;
 }

You can consider that limitSubclass is not null:

if (limitSubclass.equals(CgmesNames.ACTIVE_POWER_LIMIT) || limitSubclass.equals(CgmesNames.APPARENT_POWER_LIMIT) || limitSubclass.equals(CgmesNames.CURRENT_LIMIT)) {
    if (terminalId != null) {
    ...

[rcourtier]

Thank you for your work!

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[alicecaron]

in RegulatingControlMappingForTransformers remove the case checking control.mode.endsWith("fixed") when setting phase tap changer control as the "fixed" mode is does not exist anymore in CIM16 (CIM14 related)

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud