Skip to content

Implement move feederbay network modification #3396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Implement move feederbay network modification #3396

wants to merge 9 commits into from

Conversation

ghazwarhili
Copy link

@ghazwarhili ghazwarhili commented Apr 1, 2025 •
edited
Loading

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • A PR or issue has been opened in all impacted repositories (if any)

Does this PR already have an issue describing the problem?

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Other information:

@ghazwarhili ghazwarhili requested a review from EtienneLt April 2, 2025 07:07
@So-Fras So-Fras changed the title implement move feederbay network modification Implement move feederbay network modification Apr 2, 2025
EtienneLt
EtienneLt reviewed Apr 4, 2025
View reviewed changes
@ghazwarhili ghazwarhili requested a review from etiennehomer April 8, 2025 15:31
@ghazwarhili
code review remarks
25d0e70 
Signed-off-by: Rehili Ghazwa <[email protected]>
@ghazwarhili ghazwarhili requested a review from EtienneLt April 9, 2025 07:00
olperr1
olperr1 requested changes Apr 11, 2025
View reviewed changes
@ghazwarhili ghazwarhili marked this pull request as ready for review April 14, 2025 07:48
@ghazwarhili
code review remarks part 2
483cc5c 
Signed-off-by: Rehili Ghazwa <[email protected]>
@ghazwarhili
code review remarks
711551c 
Signed-off-by: Rehili Ghazwa <[email protected]>
@etiennehomer etiennehomer removed their request for review April 16, 2025 07:50
@ghazwarhili
add test
e3d001f 
Signed-off-by: Rehili Ghazwa <[email protected]>
@ghazwarhili
fix sonar issues
c1d845b 
Signed-off-by: Rehili Ghazwa <[email protected]>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
93.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olperr1 olperr1 olperr1 requested changes

@EtienneLt EtienneLt Awaiting requested review from EtienneLt

Requested changes must be addressed to merge this pull request.

Assignees

@ghazwarhili ghazwarhili

Labels
Release 06/2025
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ghazwarhili @EtienneLt @olperr1 @So-Fras