Skip to content

Rename test resources bundle #3398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

Lisrte
Copy link
Contributor

@Lisrte Lisrte commented Apr 7, 2025

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • A PR or issue has been opened in all impacted repositories (if any)

Does this PR already have an issue describing the problem?

No

What kind of change does this PR introduce?

Feature

What is the current behavior?

PowsyblCoreTestReportResourceBundle defined in commons-test contains only the test base name used for unit test as defined in the migration guide.

What is the new behavior (if this is a feature change)?
Rename PowsyblCoreTestReportResourceBundle to PowsyblTestReportResourceBundle in order to use it in other repositories unit test.

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

PowsyblCoreTestReportResourceBundle has been renamed to PowsyblTestReportResourceBundle.

Other information:

@Lisrte Lisrte added the Breaking Change API is broken label Apr 7, 2025
@Lisrte Lisrte self-assigned this Apr 7, 2025
Copy link

sonarqubecloud bot commented Apr 7, 2025

@Lisrte Lisrte requested review from flo-dup and alicecaron April 7, 2025 14:15
@Lisrte Lisrte marked this pull request as ready for review April 7, 2025 14:17
@alicecaron
Copy link
Contributor

alicecaron commented Apr 7, 2025

We need to open a new issue on powsybl-optimizer and powsybl-open-loadflow (with see olf#1216) at least to adapt if we merge this one as they already use this class

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants