Fix inconsistence in nodebreaker topology switches count #3678
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Giovanni Ferrari <[email protected]>
Signed-off-by: Giovanni Ferrari <[email protected]>
zamarrenolm
previously approved these changes
Dec 1, 2025
rolnico
requested changes
Dec 1, 2025
| .setNode(2) | ||
| .add(); | ||
|
|
||
| // Create 3 switches |
Member
There was a problem hiding this comment.
Suggested change
| // Create 3 switches | |
| // Create 2 switches |
Comment on lines
20
to
24
| * Test to verify consistency between getSwitches(), getSwitchStream(), and | ||
| * getSwitchCount() methods | ||
| * in node-breaker topology. These methods should all exclude | ||
| * InternalConnections and only return | ||
| * real voltage level switches. |
Member
There was a problem hiding this comment.
Suggested change
| * Test to verify consistency between getSwitches(), getSwitchStream(), and | |
| * getSwitchCount() methods | |
| * in node-breaker topology. These methods should all exclude | |
| * InternalConnections and only return | |
| * real voltage level switches. | |
| * Test to verify consistency between getSwitches(), getSwitchStream(), and | |
| * getSwitchCount() methods in node-breaker topology. These methods should all exclude | |
| * InternalConnections and only return real voltage level switches. |
Signed-off-by: Giovanni Ferrari <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
#3631
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
Other information: