Make the CGMES fullModels query less restrictive #3695
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Romain Courtier <[email protected]>
rcourtier
force-pushed
the
cgmes_fullmodel_query_less_restrictive
branch
from
f6f7eb2 to
ae04b35
Compare
olperr1
previously approved these changes
Dec 31, 2025
github-project-automation
bot
moved this from Waiting for review
to Approved
in Release 03/2026
…performed Signed-off-by: Romain Courtier <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No.
What kind of change does this PR introduce?
In between bug fix and feature.
What is the current behavior?
CGMES conversion imports first the EQ file, and then updates the network with SSH and/or SV files. To prevent unnecessary code execution, the update is being done only if a SSH and/or SV file is detected. But when the header of the SSH/SV file is not complete and the md:FullModel element is missing some attributes (like md:Model.created or md:Model.scenarioTime or md:Model.version), the fullModels SPARQL query doesn't return a result. As a consequence, the network is not updated with SSH/SV values and stays in EQUIPMENT validation level.
What is the new behavior (if this is a feature change)?
The fullModels query is less restrictive and returns a result even when the following attributes are missing:
In other words, only the id, modeling authority set and profile(s) are required.
Does this PR introduce a breaking change or deprecate an API?
Other information: