Optimize getFictitiousP0() and getFictitiousQ0() to compute over every nodes only when needed#3754
Open
SylvestreSakti wants to merge 10 commits intomainfrom
Open
Optimize getFictitiousP0() and getFictitiousQ0() to compute over every nodes only when needed#3754SylvestreSakti wants to merge 10 commits intomainfrom
SylvestreSakti wants to merge 10 commits intomainfrom
Conversation
Signed-off-by: PRABAKARAN Sylvestre <sylvestre.prabakaran@rte-france.com>
SylvestreSakti
changed the title
flo-dup
requested changes
Feb 3, 2026
| if (Double.isNaN(p0)) { | ||
| throw new ValidationException(voltageLevel, "undefined value cannot be set as fictitious p0"); | ||
| } | ||
| hasFictitiousP0.setTrue(); |
Collaborator
There was a problem hiding this comment.
Only true for current variant (and if p0 != 0). And you need to handle the setFalse also, if we switch back the value to 0 (and all others are).
|
|
||
| @Override | ||
| public boolean hasFictitiousP0() { | ||
| return hasFictitiousP0.get(); |
Collaborator
There was a problem hiding this comment.
to avoid this parameter we could check that fictitiousP0ByNode is empty, and if not sum the (abs?) values of current variant for each node
Member
Author
There was a problem hiding this comment.
Yes, this would be cleaner and without any parameter
Member
Author
There was a problem hiding this comment.
Done, currently, it is considered that any non zero value in any node of the current variant leads to hasFictitiousP0=true. I don't know if there would be the need to be more accurate (sum of the nodes ?)
Signed-off-by: PRABAKARAN Sylvestre <sylvestre.prabakaran@rte-france.com>
rolnico
requested changes
Feb 3, 2026
iidm/iidm-impl/src/main/java/com/powsybl/iidm/network/impl/NodeBreakerTopologyModel.java
Outdated
Show resolved
Hide resolved
iidm/iidm-impl/src/main/java/com/powsybl/iidm/network/impl/NodeBreakerTopologyModel.java
Outdated
Show resolved
Hide resolved
Signed-off-by: PRABAKARAN Sylvestre <sylvestre.prabakaran@rte-france.com>
Signed-off-by: PRABAKARAN Sylvestre <sylvestre.prabakaran@rte-france.com>
rolnico
reviewed
Feb 3, 2026
iidm/iidm-impl/src/main/java/com/powsybl/iidm/network/impl/CalculatedBusImpl.java
Outdated
Show resolved
Hide resolved
SylvestreSakti
changed the title
rolnico
requested changes
Feb 3, 2026
Comment on lines
650
to
660
| if (fictitiousP0ByNode.isEmpty()) { | ||
| return false; | ||
| } | ||
| int variantIndex = getNetwork().getVariantIndex(); | ||
| for (int node : fictitiousP0ByNode.keys()) { | ||
| TDoubleArrayList p0ByVariant = fictitiousP0ByNode.get(node); | ||
| if (p0ByVariant != null && p0ByVariant.get(variantIndex) != 0.0) { | ||
| return true; | ||
| } | ||
| } | ||
| return false; |
Member
There was a problem hiding this comment.
you can avoid duplication by creating a small private method with the map (fictitiousP0ByNode or fictitiousQ0ByNode) as argument
Signed-off-by: PRABAKARAN Sylvestre <sylvestre.prabakaran@rte-france.com>
Signed-off-by: PRABAKARAN Sylvestre <sylvestre.prabakaran@rte-france.com>
Signed-off-by: PRABAKARAN Sylvestre <sylvestre.prabakaran@rte-france.com>
Signed-off-by: PRABAKARAN Sylvestre <sylvestre.prabakaran@rte-france.com>
Signed-off-by: PRABAKARAN Sylvestre <sylvestre.prabakaran@rte-france.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Performance issue is observed when using
getFictitiousP0()andgetFictitiousQ0()even when there are no fictitious injection. This PR optimizes this behavior.What is the current behavior?
getFictitiousP0()andgetFictitiousQ0()always search all nodes of the bus to compute fictitious injection.What is the new behavior (if this is a feature change)?
The search is done only if there is at least one non-zero fictitious injection in the voltage level.
Does this PR introduce a breaking change or deprecate an API?