Move no specific implementation tests to tck

[samirromdhani]

Please check if the PR fulfills these requirements

• The commit message follows our guidelines
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)
• A PR or issue has been opened in all impacted repositories (if any)

Does this PR already have an issue describing the problem?

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API?

• Yes
• No

If yes, please check if the following requirements are fulfilled

• The Breaking Change or Deprecated label has been added
• The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Other information:

• Contract in TCK, impl-specific in impl
  • 3 changes from iidm-impl to tck
    • AbstractLoadDetailTest the attribute variableReactivePower in LoadDetail is required, (doc)
      Network store impl or new other implementation should keep that attribute required.
    • AbstractBusbarSectionPositionTest: an implementation for this should be added in network store, so they can fix exception type from IllegalArgumentException to ValidationException related to negative busbar index
    • AbstractTopologyTraverserTest

[rolnico]

Have you tried to run those tests on powsybl-network-store, to see how it works with the other IIDM implementation?

[samirromdhani]

Have you tried to run those tests on powsybl-network-store, to see how it works with the other IIDM implementation?

You’re right: some changes doesn’t pass with powsybl-network-store, and there also failing tests on main independently from my local test change, I plan to create an issue to track this.

Failing tests

• GeneratorStartupTest > AbstractGeneratorStartupTest.testWrongData
• NetworkTest > AbstractNetworkTest.makeMergeNetwork NullPointerException

They appear to come from recently added abstract TCK tests.

[rolnico]

Have you tried to run those tests on powsybl-network-store, to see how it works with the other IIDM implementation?

You’re right: some changes doesn’t pass with powsybl-network-store, and there also failing tests on main independently from my local test change, I plan to create an issue to track this.

Failing tests

* `GeneratorStartupTest > AbstractGeneratorStartupTest.testWrongData`

* `NetworkTest > AbstractNetworkTest.makeMergeNetwork` NullPointerException

They appear to come from recently added abstract TCK tests.

It might be normal that some tests do not pass: for example the network-store implementation is not complete, so if the test is on something not yet implemented, it will fail.
What you have to check is if the implementation covers what your tests test, and if so, if the expectations are too restrictive or not

[samirromdhani]

Have you tried to run those tests on powsybl-network-store, to see how it works with the other IIDM implementation?

You’re right: some changes doesn’t pass with powsybl-network-store, and there also failing tests on main independently from my local test change, I plan to create an issue to track this.

Failing tests

* `GeneratorStartupTest > AbstractGeneratorStartupTest.testWrongData`

* `NetworkTest > AbstractNetworkTest.makeMergeNetwork` NullPointerException

They appear to come from recently added abstract TCK tests.

It might be normal that some tests do not pass: for example the network-store implementation is not complete, so if the test is on something not yet implemented, it will fail. What you have to check is if the implementation covers what your tests test, and if so, if the expectations are too restrictive or not

I agree that network-store implementation can be not complete, based on the following test message, it may be an issue on the core side

[ERROR]   NetworkTest>AbstractNetworkTest.makeMergeNetwork:60 » NullPointer Cannot invoke "com.powsybl.iidm.network.OverloadManagementSystemAdder.setId(String)" because the return value of "com.powsybl.iidm.network.Substation.newOverloadManagementSystem()" is null

I finally made only three changes from iidm-impl to TCK.
- AbstractLoadDetailTest generic test: the attribute variableReactivePower in LoadDetail is required, (doc)
Network store impl or new other implementation should keep that attribute required.
- AbstractBusbarSectionPositionTest: generic test, an implementation for this should be added in network store.
- AbstractTopologyTraverserTest. I think only the test testTraversalOrder can be not generic.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud