Fix DGS import issue with BOM

[geofjamg]

Please check if the PR fulfills these requirements

• The commit message follows our guidelines
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)
• A PR or issue has been opened in all impacted repositories (if any)

Does this PR already have an issue describing the problem?

No

What kind of change does this PR introduce?

Bug fix

What is the current behavior?

DGS import fails when file starts with a BOM

What is the new behavior (if this is a feature change)?
DGS import is robust to BOM

Does this PR introduce a breaking change or deprecate an API?

• Yes
• No

If yes, please check if the following requirements are fulfilled

• The Breaking Change or Deprecated label has been added
• The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Other information:

[zamarrenolm]

When the branch is checkout locally (either on MacOS or in Windows) the test file BOMTest.dgs does not contain the BOM:

test/resources % hexdump -C BOMTest.dgs
00000000  24 24 47 65 6e 65 72 61  6c 3b 49 44 28 61 3a 34  |$$General;ID(a:4|
00000010  30 29 3b 44 65 73 63 72  28 61 3a 34 30 29 3b 56  |0);Descr(a:40);V|
00000020  61 6c 28 61 3a 34 30 29  0a 20 31 3b 56 65 72 73  |al(a:40). 1;Vers|
00000030  69 6f 6e 3b 35 2e 30 0a                           |ion;5.0.|
00000038

Maybe it has been lost when pushing your local changes or checking out text files from github ?.

Anyway, we have tested the change with a modified text file that has the BOM bytes and it works.

We have verified that github does not modify a text file that does contain the BOM bytes. We have pushed the branch dgs_import_bom_issue_test_bom_uploaded in case you want to use it (the ony difference with your original branch is the BOMTest.dgs file)

[rolnico]

When the branch is checkout locally (either on MacOS or in Windows) the test file BOMTest.dgs does not contain the BOM:

test/resources % hexdump -C BOMTest.dgs
00000000  24 24 47 65 6e 65 72 61  6c 3b 49 44 28 61 3a 34  |$$General;ID(a:4|
00000010  30 29 3b 44 65 73 63 72  28 61 3a 34 30 29 3b 56  |0);Descr(a:40);V|
00000020  61 6c 28 61 3a 34 30 29  0a 20 31 3b 56 65 72 73  |al(a:40). 1;Vers|
00000030  69 6f 6e 3b 35 2e 30 0a                           |ion;5.0.|
00000038

Maybe it has been lost when pushing your local changes or checking out text files from github ?.

Anyway, we have tested the change with a modified text file that has the BOM bytes and it works.

We have verified that github does not modify a text file that does contain the BOM bytes. We have pushed the branch dgs_import_bom_issue_test_bom_uploaded in case you want to use it (the ony difference with your original branch is the BOMTest.dgs file)

It should be fixed now

[geofjamg]

When the branch is checkout locally (either on MacOS or in Windows) the test file BOMTest.dgs does not contain the BOM:

test/resources % hexdump -C BOMTest.dgs
00000000  24 24 47 65 6e 65 72 61  6c 3b 49 44 28 61 3a 34  |$$General;ID(a:4|
00000010  30 29 3b 44 65 73 63 72  28 61 3a 34 30 29 3b 56  |0);Descr(a:40);V|
00000020  61 6c 28 61 3a 34 30 29  0a 20 31 3b 56 65 72 73  |al(a:40). 1;Vers|
00000030  69 6f 6e 3b 35 2e 30 0a                           |ion;5.0.|
00000038

Maybe it has been lost when pushing your local changes or checking out text files from github ?.
Anyway, we have tested the change with a modified text file that has the BOM bytes and it works.
We have verified that github does not modify a text file that does contain the BOM bytes. We have pushed the branch dgs_import_bom_issue_test_bom_uploaded in case you want to use it (the ony difference with your original branch is the BOMTest.dgs file)

It should be fixed now

Thanks!

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud