Skip to content

Powerfactory: convert ElmTrfstat as a voltage level (like ElmSubstat) #3868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
geofjamg merged 8 commits into from
Apr 17, 2026
Merged

Powerfactory: convert ElmTrfstat as a voltage level (like ElmSubstat) #3868

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
a8fdba1
ElmtrfStat as voltageLevel
marqueslanauja Dec 14, 2022
460f93d
Merge branch 'main' into powerfactory_elmtrfstat_voltageLevel
marqueslanauja Dec 14, 2022
65f01f9
Merge branch 'main' into powerfactory_elmtrfstat_voltageLevel
marqueslanauja Feb 17, 2023
815d241
Merge branch 'main' into powerfactory_elmtrfstat_voltageLevel
geofjamg Apr 8, 2026
5e9d5a5
Merge branch 'main' into powerfactory_elmtrfstat_voltageLevel
geofjamg Apr 14, 2026
e3c9075
Merge branch 'main' into powerfactory_elmtrfstat_voltageLevel
marqueslanauja Apr 15, 2026
2052d96
Add unit test
marqueslanauja Apr 16, 2026
a4cf980
Merge branch 'main' into powerfactory_elmtrfstat_voltageLevel
geofjamg Apr 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 34 additions & 8 deletions ...y-converter/src/main/java/com/powsybl/powerfactory/converter/ContainersMappingHelper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,10 @@ private String getPowerFactorySubstationId(Set<Integer> ids) {

Set<DataObject> elmTerms = elmTermsAssociatedTo(ids);
Set<DataObject> elmSubstats = elmSubstatsAssociatedTo(elmTerms);
Set<DataObject> elmTrfstats = elmTrfstatsAssociatedTo(elmTerms);

Set<DataObject> elmSites = elmSitesAssociatedTo(elmSubstats);
elmSites.addAll(elmSitesAssociatedTo(elmTrfstats));

if (elmSites.size() != 1) {
return null;
Expand All @@ -107,22 +110,38 @@ private String getPowerFactorySubstationId(Set<Integer> ids) {
return elmSubstats.equals(dataObjects) ? elmSite.getLocName() : null;
}

// Find an ElmSubstat with same ElmTerms (Nodes) as defined by the ids argument
// Find an ElmSubstat or an ElmTrfstat with same ElmTerms (Nodes) as defined by the ids argument
private String getPowerFactoryVoltageLevelId(Set<Integer> ids) {

Set<DataObject> elmTerms = elmTermsAssociatedTo(ids);
Set<DataObject> elmSubstats = elmSubstatsAssociatedTo(elmTerms);

if (elmSubstats.size() != 1) {
return null;
if (elmSubstats.size() == 1) {
DataObject elmSubstat = elmSubstats.iterator().next();

Set<DataObject> dataObjects = elmSubstat.getChildren().stream()
.filter(dataObject -> dataObject.getDataClassName().equals(DataAttributeNames.ELMTERM))
.collect(Collectors.toSet());

if (elmTerms.equals(dataObjects)) {
return elmSubstat.getLocName();
}
}
DataObject elmSubstat = elmSubstats.iterator().next();

Set<DataObject> dataObjects = elmSubstat.getChildren().stream()
.filter(dataObject -> dataObject.getDataClassName().equals(DataAttributeNames.ELMTERM))
.collect(Collectors.toSet());
Set<DataObject> elmTrfstats = elmTrfstatsAssociatedTo(elmTerms);
if (elmTrfstats.size() == 1) {
DataObject elmTrfstat = elmTrfstats.iterator().next();

Set<DataObject> dataObjects = elmTrfstat.getChildren().stream()
.filter(dataObject -> dataObject.getDataClassName().equals(DataAttributeNames.ELMTERM))
.collect(Collectors.toSet());

return elmTerms.equals(dataObjects) ? elmSubstat.getLocName() : null;
if (elmTerms.equals(dataObjects)) {
return elmTrfstat.getLocName();
}
}

return null;
}

private Set<DataObject> elmTermsAssociatedTo(Set<Integer> ids) {
Expand All @@ -132,12 +151,19 @@ private Set<DataObject> elmTermsAssociatedTo(Set<Integer> ids) {
.collect(Collectors.toSet());
}

private Set<DataObject> elmTrfstatsAssociatedTo(Set<DataObject> elmTerms) {
return elmTerms.stream().map(DataObject::getParent)
.filter(dataObject -> dataObject.getDataClassName().equals(DataAttributeNames.ELMTRFSTAT))
.collect(Collectors.toSet());
}

private Set<DataObject> elmSubstatsAssociatedTo(Set<DataObject> elmTerms) {
return elmTerms.stream().map(DataObject::getParent)
.filter(dataObject -> dataObject.getDataClassName().equals(DataAttributeNames.ELMSUBSTAT))
.collect(Collectors.toSet());
}

// valid for elmSubstats and elmTrfstats
private Set<DataObject> elmSitesAssociatedTo(Set<DataObject> elmSubstats) {
return elmSubstats.stream().map(DataObject::getParent)
.filter(dataObject -> dataObject.getDataClassName().equals(DataAttributeNames.ELMSITE))
Expand Down
1 change: 1 addition & 0 deletions ...actory-converter/src/main/java/com/powsybl/powerfactory/converter/DataAttributeNames.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ private DataAttributeNames() {

static final String TYP_ID = "typ_id";
static final String ELMTERM = "ElmTerm";
static final String ELMTRFSTAT = "ElmTrfstat";
static final String ELMSUBSTAT = "ElmSubstat";
static final String ELMSITE = "ElmSite";
static final String OBJ_ID = "obj_id";
Expand Down
6 changes: 4 additions & 2 deletions powerfactory/powerfactory-converter/src/test/resources/VoltageLevelsAndSubstations.dgs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,8 +78,10 @@ $$TypTr2;ID(a:40);loc_name(a:40);for_name(a:50);fold_id(p);nt2ph(i);strn(r);frno
$$ElmSubstat;ID(a:40);loc_name(a:40);for_name(a:50);fold_id(p);sShort(a:6);sType(a:80);GPSlat(r);GPSlon(r)
31;VoltageLevel1-400;;34;;;49,95646302;11,45051847
32;VoltageLevel2-400;;35;;;49,95646302;11,45051847
33;VoltageLevel2-20;;35;;;49,95646302;11,45051847


$$ElmTrfstat;ID(a:40);loc_name(a:40);for_name(a:50);fold_id(p)
33;VoltageLevel2-20;;35

$$ElmSite;ID(a:40);loc_name(a:40);for_name(a:50);fold_id(p);sType(a:80);GPSlat(r);GPSlon(r)
34;Substation1;;8;;49,95646302;11,45051847
35;Substation2;;8;;50,89789337;11,01545826
Expand Down
Loading