Skip to content

Add coverage detection on WindowsLocalCommandExecutor#3979

Merged
olperr1 merged 1 commit into
mainfrom
coverage_detection
Jun 26, 2026
Merged

Add coverage detection on WindowsLocalCommandExecutor#3979
olperr1 merged 1 commit into
mainfrom
coverage_detection

Conversation

@olperr1

@olperr1 olperr1 commented Jun 26, 2026

Copy link
Copy Markdown
Member

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • A PR or issue has been opened in all impacted repositories (if any)

Does this PR already have an issue describing the problem?

No

What kind of change does this PR introduce?

Quality (kind of)

What is the current behavior?

Existing unit tests on WindowsLocalCommandExecutor are run on Windows machine only.
Our workflow executes on Unix, Windows and MacOS, but the code coverage is only computed on Unix. Therefore WindowsLocalCommandExecutor appears as non-tested.

What is the new behavior (if this is a feature change)?
All the WindowsLocalCommandExecutor that don't finally execute a system command are run on every OS. As a consequence, they are taken into account for the code coverage.

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Other information:

Signed-off-by: Olivier Perrin <olivier.perrin@rte-france.com>
@olperr1 olperr1 self-assigned this Jun 26, 2026
@olperr1 olperr1 requested a review from rolnico June 26, 2026 14:34
@sonarqubecloud

Copy link
Copy Markdown

@olperr1 olperr1 merged commit 19c79e6 into main Jun 26, 2026
9 checks passed
@olperr1 olperr1 deleted the coverage_detection branch June 26, 2026 14:55
olperr1 added a commit that referenced this pull request Jun 26, 2026
Signed-off-by: Olivier Perrin <olivier.perrin@rte-france.com>
(cherry picked from commit 19c79e6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants