Add coverage detection on WindowsLocalCommandExecutor#3979
Merged
Conversation
Signed-off-by: Olivier Perrin <olivier.perrin@rte-france.com>
|
rolnico
approved these changes
Jun 26, 2026
olperr1
added a commit
that referenced
this pull request
Jun 26, 2026
Signed-off-by: Olivier Perrin <olivier.perrin@rte-france.com> (cherry picked from commit 19c79e6)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Quality (kind of)
What is the current behavior?
Existing unit tests on
WindowsLocalCommandExecutorare run on Windows machine only.Our workflow executes on Unix, Windows and MacOS, but the code coverage is only computed on Unix. Therefore
WindowsLocalCommandExecutorappears as non-tested.What is the new behavior (if this is a feature change)?
All the
WindowsLocalCommandExecutorthat don't finally execute a system command are run on every OS. As a consequence, they are taken into account for the code coverage.Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
Other information: