Skip to content

NAD custom style provider#678

Merged
flo-dup merged 19 commits intomainfrom
custom_style_provider
Mar 26, 2025
Merged

NAD custom style provider#678
flo-dup merged 19 commits intomainfrom
custom_style_provider

Conversation

@CBiasuzzi
Copy link
Copy Markdown
Contributor

@CBiasuzzi CBiasuzzi commented Mar 13, 2025

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • A PR or issue has been opened in all impacted repositories (if any)

Does this PR already have an issue describing the problem?

What kind of change does this PR introduce?

feature: provides a custom style provider; it allows you to specify the styles for

  • bus nodes: in terms of fill color, edge color, edge width
  • edges: in terms of edge color, edge width, and edge dash (pattern create a dashed line) for each side of the line
  • three winding transformers: in terms of edge color, edge width, and edge dash (pattern create a dashed line) for each transformer's leg

Note that this PR needs PR #671

What is the current behavior?

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Other information:

flo-dup and others added 13 commits February 20, 2025 10:22
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Christian Biasuzzi <christian.biasuzzi@soft.it>
Signed-off-by: Christian Biasuzzi <christian.biasuzzi@soft.it>
Signed-off-by: Christian Biasuzzi <christian.biasuzzi@soft.it>
Signed-off-by: Christian Biasuzzi <christian.biasuzzi@soft.it>
@flo-dup flo-dup force-pushed the custom_style_provider branch from 3dabde9 to 3225435 Compare March 25, 2025 11:19
Comment thread network-area-diagram/src/main/java/com/powsybl/nad/svg/CustomStyleProvider.java Outdated
Comment thread network-area-diagram/src/main/resources/customStyle.css Outdated
/**
* @author Christian Biasuzzi {@literal <christian.biasuzzi at soft.it>}
*/
public class CustomStyleProvider extends AbstractStyleProvider {
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AbstractStyleProvider has all the baseVoltage / disconnection which we don't care... We should probably do some cleaning in AbstractStyleProvider, but let's keep that for another PR

@flo-dup flo-dup moved this from TODO to In Progress in Release 03/2025 Mar 25, 2025
Signed-off-by: Christian Biasuzzi <christian.biasuzzi@soft.it>
Signed-off-by: Christian Biasuzzi <christian.biasuzzi@soft.it>
@CBiasuzzi CBiasuzzi changed the title [WIP] NAD custom style provider NAD custom style provider Mar 25, 2025
@github-project-automation github-project-automation bot moved this from In Progress to Approved in Release 03/2025 Mar 26, 2025
@sonarqubecloud
Copy link
Copy Markdown

@flo-dup flo-dup merged commit 38b0ca3 into main Mar 26, 2025
8 checks passed
@flo-dup flo-dup deleted the custom_style_provider branch March 26, 2025 13:56
@github-project-automation github-project-automation bot moved this from Approved to Done in Release 03/2025 Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants