Skip to content

Custom stylesheet fixes#687

Merged
flo-dup merged 1 commit intomainfrom
custom_style_css_fix
Mar 28, 2025
Merged

Custom stylesheet fixes#687
flo-dup merged 1 commit intomainfrom
custom_style_css_fix

Conversation

@CBiasuzzi
Copy link
Copy Markdown
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • A PR or issue has been opened in all impacted repositories (if any)

Does this PR already have an issue describing the problem?

no

What kind of change does this PR introduce?

fix

What is the current behavior?

there could be some style-overriding issues, with NADs - e.g., when multiple diagrams are in the same html page
and the last one happens to use the custom style.

What is the new behavior (if this is a feature change)?

in the customStyle.css: we keep the var(--nad-vl-color, DEFAULT_VALUE) approach used in the other stylesheets, to prevent the issue.

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Other information:

Signed-off-by: Christian Biasuzzi <christian.biasuzzi@soft.it>
@sonarqubecloud
Copy link
Copy Markdown

@flo-dup flo-dup merged commit f0799cf into main Mar 28, 2025
8 checks passed
@flo-dup flo-dup deleted the custom_style_css_fix branch March 28, 2025 15:16
@So-Fras So-Fras changed the title custom stylesheet fixes Custom stylesheet fixes Mar 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants