Style tables in text boxes using CSS #690
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Giovanni Ferrari <[email protected]>
quinarygio
force-pushed
the
685-nad-css-tables-in-text-boxes
branch
from
11f79fa to
d6c7ce7
Compare
flo-dup
requested changes
Apr 4, 2025
Comment on lines
2594
to
2603
| <div class="nad-table"> | ||
| <div class="nad-row"> | ||
| <div class="nad-vl0to30-1 nad-cell nad-legend-square"/> | ||
| <div class="nad-cell">1.1 kV / -12.5°</div> | ||
| </div> | ||
| <div class="nad-row"> | ||
| <div class="nad-vl0to30-0 nad-cell nad-legend-square"/> | ||
| <div class="nad-cell">1.0 kV / -11.4°</div> | ||
| </div> | ||
| </div> |
There was a problem hiding this comment.
See issue comment
Suggested change
| <div class="nad-table"> | |
| <div class="nad-row"> | |
| <div class="nad-vl0to30-1 nad-cell nad-legend-square"/> | |
| <div class="nad-cell">1.1 kV / -12.5°</div> | |
| </div> | |
| <div class="nad-row"> | |
| <div class="nad-vl0to30-0 nad-cell nad-legend-square"/> | |
| <div class="nad-cell">1.0 kV / -11.4°</div> | |
| </div> | |
| </div> | |
| <div> | |
| <div><span class="nad-vl0to30-1 nad-legend-square"/>1.1 kV / -12.5°</div> | |
| <div><span class="nad-vl0to30-0 nad-legend-square"/>1.0 kV / -11.4°</div> | |
| </div> |
with simpler CSS
.nad-legend-square {display: inline-block; width: 20px; height: 20px; background: var(--nad-vl-color, black); margin-right: 10px;}There was a problem hiding this comment.
I think we can get rid of nad-table, nad-row and nad-cell CSS classes
Signed-off-by: Giovanni Ferrari <[email protected]>
flo-dup
requested changes
Apr 10, 2025
| <td> kV / °</td> | ||
| </tr> | ||
| </table> | ||
| <div> |
There was a problem hiding this comment.
do we need this div? it's to separate from header / footer?
Comment on lines
209
to
210
| <div> | ||
| <span class="nad-legend-square"/> kV / °</div> |
There was a problem hiding this comment.
would be clearer to have this on one line only
Signed-off-by: Giovanni Ferrari <[email protected]>
Signed-off-by: Giovanni Ferrari <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
Fixes #685