NAD: Use single foreignObject for all text nodes #691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Giovanni Ferrari <[email protected]>
flo-dup
requested changes
Apr 4, 2025
Comment on lines
680
to
681
| <g class="nad-text-nodes"> | ||
| <foreignObject id="0-textnode" y="-937.76" x="479.50" height="1" width="1"> |
There was a problem hiding this comment.
the g tag and the foreignObject can be merged together
| @@ -679,7 +679,7 @@ path.nad-arrow-in:not(.nad-state-in .nad-arrow-in) {visibility: hidden} | |||
| </g> | |||
| <g class="nad-text-nodes"> | |||
| <foreignObject id="0-textnode" y="-937.76" x="479.50" height="1" width="1"> | |||
| <div xmlns="http://www.w3.org/1999/xhtml" class="nad-label-box"> | |||
| <div xmlns="http://www.w3.org/1999/xhtml" class="nad-label-box" style="position: absolute; top: 0px; left: 0px" id="0-textnode"> | |||
There was a problem hiding this comment.
could we avoid to repeat the name space in all the divs or is it required? Or is it allowed to put it in the foreignObject?
There was a problem hiding this comment.
Namespace is required and it is not possible to put it in foreignObject. I added a
after foreignObject with the declaration of the namespace to avoid repetition
| @@ -679,7 +679,7 @@ path.nad-arrow-in:not(.nad-state-in .nad-arrow-in) {visibility: hidden} | |||
| </g> | |||
| <g class="nad-text-nodes"> | |||
| <foreignObject id="0-textnode" y="-937.76" x="479.50" height="1" width="1"> | |||
There was a problem hiding this comment.
It would make more sense to put the foreignObject in 0,0
Signed-off-by: Giovanni Ferrari <[email protected]>
Signed-off-by: Giovanni Ferrari <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
Fixes #684
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
Other information: