Skip to content

[NAD] Add generators subtypes icons#699

Draft
flo-dup wants to merge 39 commits intomainfrom
add_generators_subtypes
Draft

[NAD] Add generators subtypes icons#699
flo-dup wants to merge 39 commits intomainfrom
add_generators_subtypes

Conversation

@flo-dup
Copy link
Copy Markdown
Collaborator

@flo-dup flo-dup commented Jun 12, 2025

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • A PR or issue has been opened in all impacted repositories (if any)

Does this PR already have an issue describing the problem?
No

What kind of change does this PR introduce?
Feature

What is the current behavior?
All generators are displayed the same way

What is the new behavior (if this is a feature change)?
Generators are displayed differently depending on their energy source

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

Capture d’écran du 2025-06-12 15-38-22

flo-dup added 30 commits July 7, 2025 16:03
@flo-dup
Refactor loop angles computing for reusing it
257b879 
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup
Add injections and injections angles computation
455fc65 
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup
Add holes in rings for traversing injections
2172cf6 
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup
Injection implements Identifiable
626b85d 
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup
Injection does not hold p and q
1aaf063 
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup
Injection has edge points parameters
55253c9 
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup
Add injection edges
e5df064 
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup
Add circle injection + connectable injections
1a7e89e 
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup
Draw injection icon
478a203 
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup
Clean visitor
d8ee9de 
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup
Fix components.json
8f6d1d3 
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup
Clean svc.svg
589d9af 
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup
Fix topological injections colors
93ef381 
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup
Add unit test
72bf459 
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup
Clean
5c8d097 
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup
Update unit test references
f637225 
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup
Move isCapacitor test
9b84c40 
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup
Graph builder workaround due to powsybl-core connectable bug
d18b2c6 
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup
Clean unknown-component.svg
cb3da7c 
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup
Clean components.json
8d44851 
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup
Add battery in test
5c46993 
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup
Fix code smells
81ce648 
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup
Remove TODO
8262b5d 
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup
Fix remaining code smell
d05c8b8 
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup
Add injections to metadata
5536aea 
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup
Replacing SvgStAXResult by SvgContentHandlerToXMLStreamWriter + comments
af01d13 
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup
Fix the insert angles logic
96eca81 
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup
Slots should remove starting from the smallest SLICED intervals
79fcb24 
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup
Update test references
e933877 
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup
Fix checkstyle
1730580 
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
flo-dup added 3 commits July 8, 2025 16:54
@flo-dup
Update unit tests references
3fafd88 
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup
Fix unit test: only create injection group element if needed
b0b2720 
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup
Fix checkstyle
e1bbfbe 
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup flo-dup force-pushed the add_generators_subtypes branch from 11c4b55 to e1bbfbe Compare July 8, 2025 14:54
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Jul 8, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
92.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@flo-dup flo-dup force-pushed the fix_insert_angles_logic branch from c266154 to 0efa485 Compare July 9, 2025 13:48
Base automatically changed from fix_insert_angles_logic to main July 9, 2025 14:53
@alicecaron alicecaron moved this from TODO to In Progress in Release 09/2025 Sep 9, 2025
@flo-dup flo-dup moved this from TODO to In Progress in Release 12/2025 Oct 16, 2025
@alicecaron alicecaron moved this from TODO to In Progress in Release 03/2026 Jan 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Release 06/2026

Projects

Release 06/2026
Status: TODO

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@flo-dup @So-Fras @alicecaron