Conversation
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>
…+ fix WireMetadata Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>
|
alicecaron
reviewed
Apr 13, 2026
| if (subComponents != null && !subComponents.isEmpty()) { | ||
| Element group = document.createElement(GROUP); | ||
| group.setAttribute("id", c); | ||
| group.setAttribute("id", c); // TODO: check here |
There was a problem hiding this comment.
todo to solve? what needs to be checked?
| drawVoltageLevel(network, voltageLevelId, svgFile, new SldParameters()); | ||
| } | ||
|
|
||
| public static void drawVoltageLevel(Network network, String voltageLevelId, Path svgFile, IdProvider idProvider) { |
Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>
Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>
Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>
…eDiagramTest` Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>
Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Feature
What is the current behavior?
In SLD, the ids used in the SVGs are created by prepending the network element ids with
idand by replacing non-alphanumeric characters with their unicode value.What is the new behavior (if this is a feature change)?
An
IdProvidercan now be given to thedrawmethods to specify how the ids should be generated.Default behavior is still the same, using
LegacyIdProvider. A new IdProvider is also available, it works as in NAD and generates the ids by counting the elements.Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
Other information: