[SLD] Represent nodes/buses fictitious injections#794
Merged
Conversation
samirromdhani
force-pushed
the
feat/741-represent-nodesbuses-fictitious-injections-in-sld
branch
5 times, most recently
from
ff1d577 to
d71e8c2
Compare
samirromdhani
force-pushed
the
feat/741-represent-nodesbuses-fictitious-injections-in-sld
branch
from
d71e8c2 to
dbde9dd
Compare
rolnico
requested changes
Mar 13, 2026
rolnico
requested changes
Mar 24, 2026
samirromdhani
force-pushed
the
feat/741-represent-nodesbuses-fictitious-injections-in-sld
branch
2 times, most recently
from
fac6c88 to
c5a66e3
Compare
Signed-off-by: Samir Romdhani <samir.romdhani_externe@rte-france.com> test remove debugSvgFiles Signed-off-by: Samir Romdhani <samir.romdhani_externe@rte-france.com> review sonar Signed-off-by: Samir Romdhani <samir.romdhani_externe@rte-france.com>
Signed-off-by: Samir Romdhani <samir.romdhani_externe@rte-france.com>
samirromdhani
force-pushed
the
feat/741-represent-nodesbuses-fictitious-injections-in-sld
branch
from
c5a66e3 to
12faf78
Compare
rolnico
reviewed
Mar 26, 2026
samirromdhani
force-pushed
the
feat/741-represent-nodesbuses-fictitious-injections-in-sld
branch
from
adbbb54 to
b253fa5
Compare
rolnico
requested changes
Mar 26, 2026
Comment on lines
+62
to
+68
| .map(bus -> new BusLegendInfo(bus.getId(), List.of( | ||
| new BusLegendInfo.Caption(valueFormatter.formatVoltage(bus.getV(), "kV"), "v"), | ||
| new BusLegendInfo.Caption(valueFormatter.formatAngleInDegrees(bus.getAngle()), "angle"), | ||
| new BusLegendInfo.Caption(valueFormatter.formatPower(bus.getFictitiousP0(), withDefaultUnit(svgParameters.getActivePowerUnit(), "MW")), "fictitiousP0"), | ||
| new BusLegendInfo.Caption(valueFormatter.formatPower(bus.getFictitiousQ0(), withDefaultUnit(svgParameters.getReactivePowerUnit(), "MVar")), "fictitiousQ0") | ||
| ))) | ||
| .toList(); |
Member
There was a problem hiding this comment.
Suggested change
| .map(bus -> new BusLegendInfo(bus.getId(), List.of( | |
| new BusLegendInfo.Caption(valueFormatter.formatVoltage(bus.getV(), "kV"), "v"), | |
| new BusLegendInfo.Caption(valueFormatter.formatAngleInDegrees(bus.getAngle()), "angle"), | |
| new BusLegendInfo.Caption(valueFormatter.formatPower(bus.getFictitiousP0(), withDefaultUnit(svgParameters.getActivePowerUnit(), "MW")), "fictitiousP0"), | |
| new BusLegendInfo.Caption(valueFormatter.formatPower(bus.getFictitiousQ0(), withDefaultUnit(svgParameters.getReactivePowerUnit(), "MVar")), "fictitiousQ0") | |
| ))) | |
| .toList(); | |
| .map(bus -> new BusLegendInfo(bus.getId(), List.of( | |
| new BusLegendInfo.Caption(valueFormatter.formatVoltage(bus.getV(), "kV"), "v"), | |
| new BusLegendInfo.Caption(valueFormatter.formatAngleInDegrees(bus.getAngle()), "angle"), | |
| new BusLegendInfo.Caption(valueFormatter.formatPower(bus.getFictitiousP0(), | |
| withDefaultUnit(svgParameters.getActivePowerUnit(), "MW")), "fictitiousP0"), | |
| new BusLegendInfo.Caption(valueFormatter.formatPower(bus.getFictitiousQ0(), | |
| withDefaultUnit(svgParameters.getReactivePowerUnit(), "MVar")), "fictitiousQ0") | |
| ))) | |
| .toList(); |
Contributor
Author
There was a problem hiding this comment.
Actually formatted with IntelliJ (using the default configuration), i had to add .editorconfig locally to adjust indentation to 4 as you suggested.
Even with the new checkstyle version (powsybl/powsybl-parent#90) the indentation i set still work, maybe we should align on a common style with an operational checkstyle rule ?
suggestion applied 🆗
Member
There was a problem hiding this comment.
The idea is also to keep the code formatting consistent, so to not change the code that does not need to be changed.
Contributor
Author
There was a problem hiding this comment.
I agree, but code formatting can be changed mostly in cases like refactoring, in this case we can't detect easily if the formatting kept consistent or not if there is no common style, also define such common style can prevent conflicts during code reviews.
Signed-off-by: Samir Romdhani <samir.romdhani_externe@rte-france.com>
rolnico
approved these changes
Mar 26, 2026
|
rolnico
deleted the
feat/741-represent-nodesbuses-fictitious-injections-in-sld
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
Fixes #741
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
Other information: