Skip to content

Add power angle model#668

Draft
Lisrte wants to merge 4 commits into
mainfrom
power_angle_model
Draft

Add power angle model#668
Lisrte wants to merge 4 commits into
mainfrom
power_angle_model

Conversation

@Lisrte
Copy link
Copy Markdown
Collaborator

@Lisrte Lisrte commented Jun 2, 2026

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • A PR or issue has been opened in all impacted repositories (if any)

Does this PR already have an issue describing the problem?

No

What kind of change does this PR introduce?

Feature

What is the current behavior?

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

MacroConnectionsAdder constructor

MacroConnectionsAdder(
  Function<String, BlackBoxModel> dynamicModelGetter,
  Function<String, BlackBoxModel> pureDynamicModelGetter,
  Consumer<MacroConnect> macroConnectAdder,
  BiConsumer<String, Function<String, MacroConnector>> macroConnectorAdder,
  ReportNode reportNode)

have been replaced with

MacroConnectionsAdder(
  BlackBoxModelSupplier blackBoxModelSupplier,
  Consumer<MacroConnect> macroConnectAdder,
  BiConsumer<String, Function<String, MacroConnector>> macroConnectorAdder,
  ReportNode reportNode)

Other information:

Lisrte added 2 commits June 1, 2026 17:20
Add createMacroConnectionsForAll
Refactor MacroConnectionsAdder constructor

Signed-off-by: lisrte <laurent.issertial_externe@rte-france.com>
Signed-off-by: lisrte <laurent.issertial_externe@rte-france.com>
@Lisrte Lisrte added the Breaking Change API is broken label Jun 2, 2026
Lisrte added 2 commits June 3, 2026 14:09
Signed-off-by: lisrte <laurent.issertial_externe@rte-france.com>
Signed-off-by: lisrte <laurent.issertial_externe@rte-france.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Breaking Change API is broken

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant