Fix special method declaration order#311
Open
mathbagu wants to merge 14 commits into
Open
Conversation
sebalaig
requested changes
Apr 9, 2021
sebalaig
left a comment
sebalaig
left a comment
Contributor
There was a problem hiding this comment.
It looks like the following files should also be updated:
- ExtensionAdder.hpp
- SlackTerminalAdder.hpp
Additional/related inconsistencies:
- Destructor is declared twice in SwitchAdder
Author
|
@sebalaig I don't understand your last comment. Do you run a script and miss that the |
mathbagu
changed the title
Contributor
You're right, I did not check they were in different classes :/ |
Signed-off-by: Sébastien LAIGRE <slaigre@silicom.fr>
sebalaig
force-pushed
the
fix-special-method-declaration-order
branch
from
58e1660 to
4d6ab66
Compare
|
Kudos, SonarCloud Quality Gate passed! |
Signed-off-by: Sébastien LAIGRE <slaigre@silicom.fr>
Signed-off-by: Gautier Bureau <gautier.bureau@gmail.com>
…r in NodeBreakerVoltageLevel::invalidateCache() Signed-off-by: Sébastien LAIGRE <slaigre@silicom.fr>
Signed-off-by: Mathieu BAGUE <mathieu.bague@rte-france.com>
Signed-off-by: Mathieu BAGUE <mathieu.bague@rte-france.com>
Signed-off-by: Sébastien LAIGRE <slaigre@silicom.fr>
sebalaig
force-pushed
the
fix-special-method-declaration-order
branch
from
4d6ab66 to
5f5e185
Compare
sebalaig
changed the title
|
Kudos, SonarCloud Quality Gate passed! |
mathbagu
force-pushed
the
integration/v1.5.0
branch
from
1caf465 to
db78e41
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements (please use
'[x]'to check the checkboxes, or submit the PR and then click the checkboxes)Does this PR already have an issue describing the problem ? If so, link to this issue using
'#XXX'and skip the rest#312
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Coding style
What is the current behavior? (You can also link to an open issue here)
The copy and move constructors are declared after the destructor
What is the new behavior (if this is a feature change)?
The copy and move constructors are declared before the destructor, with other contructors
Does this PR introduce a breaking change or deprecate an API? If yes, check the following:
Other information:
(if any of the questions/checkboxes don't apply, please delete them entirely)