Skip to content

reference pointer can be null if no terminalRef#458

Open
edouardChevreau wants to merge 2 commits into
mainfrom
457_RatioTapChangerValidation
Open

reference pointer can be null if no terminalRef#458
edouardChevreau wants to merge 2 commits into
mainfrom
457_RatioTapChangerValidation

Conversation

@edouardChevreau

@edouardChevreau edouardChevreau commented Jun 4, 2025

Copy link
Copy Markdown
Collaborator

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • A PR or issue has been opened in all impacted repositories (if any)

Does this PR already have an issue describing the problem?

Fixes #457

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Other information:

@edouardChevreau edouardChevreau force-pushed the 457_RatioTapChangerValidation branch 6 times, most recently from 45bad5d to fb1b74e Compare June 6, 2025 13:29
@edouardChevreau edouardChevreau force-pushed the 457_RatioTapChangerValidation branch from 8c6d146 to 314e677 Compare June 30, 2025 14:25
Signed-off-by: Edouard Chevreau <edouard.chevreau@dps-fr.com>

Specific boost package version for linux build and explicit include for windows build

Signed-off-by: Edouard Chevreau <edouard.chevreau@dps-fr.com>

Remove dangling reference warning

Signed-off-by: Edouard Chevreau <edouard.chevreau@dps-fr.com>

False positive warning GNU comilator

Signed-off-by: Edouard Chevreau <edouard.chevreau@dps-fr.com>

Use temporary reference object in before usage

Signed-off-by: Edouard Chevreau <edouard.chevreau@dps-fr.com>

Local temporary reference in getQ as well

Signed-off-by: Edouard Chevreau <edouard.chevreau@dps-fr.com>

Other places with dangling reference

Signed-off-by: Edouard Chevreau <edouard.chevreau@dps-fr.com>

Other dangling references

Signed-off-by: Edouard Chevreau <edouard.chevreau@dps-fr.com>

Still fixing dangling references

Signed-off-by: Edouard Chevreau <edouard.chevreau@dps-fr.com>

Other kind of  dangling references

Signed-off-by: Edouard Chevreau <edouard.chevreau@dps-fr.com>

Proceeed to get all warnings

Signed-off-by: Edouard Chevreau <edouard.chevreau@dps-fr.com>

Change boost version in clang ci as well

Signed-off-by: Edouard Chevreau <edouard.chevreau@dps-fr.com>

Reset -Werror but exception on dangling reference

Signed-off-by: Edouard Chevreau <edouard.chevreau@dps-fr.com>

Dangling reference issue only since gcc 13

Signed-off-by: Edouard Chevreau <edouard.chevreau@dps-fr.com>

Keep only changes relative to the 457 and some cleanings

Signed-off-by: Edouard Chevreau <edouard.chevreau@dps-fr.com>

Not relevant

Signed-off-by: Edouard Chevreau <edouard.chevreau@dps-fr.com>

Fix CI Windows and linux

Signed-off-by: Edouard Chevreau <edouard.chevreau@dps-fr.com>

include chrono

Signed-off-by: Edouard Chevreau <edouard.chevreau@dps-fr.com>
Signed-off-by: Edouard Chevreau <edouard.chevreau@dps-fr.com>

include chrono

Signed-off-by: Edouard Chevreau <edouard.chevreau@dps-fr.com>

Ignore unknown warnings in clangtidy config

Signed-off-by: Edouard Chevreau <edouard.chevreau@dps-fr.com>
@edouardChevreau edouardChevreau force-pushed the 457_RatioTapChangerValidation branch from 314e677 to 70a6186 Compare June 30, 2025 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant