reference pointer can be null if no terminalRef#458
Open
edouardChevreau wants to merge 2 commits into
Open
Conversation
45bad5d to
fb1b74e
Compare
8c6d146 to
314e677
Compare
Signed-off-by: Edouard Chevreau <edouard.chevreau@dps-fr.com> Specific boost package version for linux build and explicit include for windows build Signed-off-by: Edouard Chevreau <edouard.chevreau@dps-fr.com> Remove dangling reference warning Signed-off-by: Edouard Chevreau <edouard.chevreau@dps-fr.com> False positive warning GNU comilator Signed-off-by: Edouard Chevreau <edouard.chevreau@dps-fr.com> Use temporary reference object in before usage Signed-off-by: Edouard Chevreau <edouard.chevreau@dps-fr.com> Local temporary reference in getQ as well Signed-off-by: Edouard Chevreau <edouard.chevreau@dps-fr.com> Other places with dangling reference Signed-off-by: Edouard Chevreau <edouard.chevreau@dps-fr.com> Other dangling references Signed-off-by: Edouard Chevreau <edouard.chevreau@dps-fr.com> Still fixing dangling references Signed-off-by: Edouard Chevreau <edouard.chevreau@dps-fr.com> Other kind of dangling references Signed-off-by: Edouard Chevreau <edouard.chevreau@dps-fr.com> Proceeed to get all warnings Signed-off-by: Edouard Chevreau <edouard.chevreau@dps-fr.com> Change boost version in clang ci as well Signed-off-by: Edouard Chevreau <edouard.chevreau@dps-fr.com> Reset -Werror but exception on dangling reference Signed-off-by: Edouard Chevreau <edouard.chevreau@dps-fr.com> Dangling reference issue only since gcc 13 Signed-off-by: Edouard Chevreau <edouard.chevreau@dps-fr.com> Keep only changes relative to the 457 and some cleanings Signed-off-by: Edouard Chevreau <edouard.chevreau@dps-fr.com> Not relevant Signed-off-by: Edouard Chevreau <edouard.chevreau@dps-fr.com> Fix CI Windows and linux Signed-off-by: Edouard Chevreau <edouard.chevreau@dps-fr.com> include chrono Signed-off-by: Edouard Chevreau <edouard.chevreau@dps-fr.com>
Signed-off-by: Edouard Chevreau <edouard.chevreau@dps-fr.com> include chrono Signed-off-by: Edouard Chevreau <edouard.chevreau@dps-fr.com> Ignore unknown warnings in clangtidy config Signed-off-by: Edouard Chevreau <edouard.chevreau@dps-fr.com>
314e677 to
70a6186
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
Fixes #457
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
Other information: