Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow use of bus-breaker voltage levels #169

Merged
merged 12 commits into from
Nov 8, 2024
Merged

Conversation

rolnico
Copy link
Member

@rolnico rolnico commented Sep 25, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?
No

What kind of change does this PR introduce?
Feature

What is the current behavior?
An exception is thrown if a switch in a bus-breaker voltage level is mapped.
A NullPointerException is thrown if the network contains dangling lines.
Switches next to lines and two windings transformers are set to retained and appear in the list of quadripoles.

What is the new behavior (if this is a feature change)?
Switches from bus-breaker voltage level are managed.
No more NullPointerException is thrown for dangling lines --> will be in #172
Switches next to lines and two windings transformers are not anymore set to retained and therefore do not appear in the list of quadripoles.

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Other information:

…ite addElementToRetainedBreakersList to manage switches from BUS_BREAKER voltage levels + remove exception + add TODO on T3T

Signed-off-by: Nicolas Rol <[email protected]>
@rolnico rolnico requested a review from marifunf September 25, 2024 09:27
@rolnico rolnico self-assigned this Sep 25, 2024
@rolnico rolnico changed the title Allow use of bus-breaker voltage levels Allow use of bus-breaker voltage levels and dangling lines Sep 25, 2024
@rolnico rolnico marked this pull request as ready for review September 25, 2024 13:26
@rolnico rolnico marked this pull request as draft September 26, 2024 06:43
Copy link

@rolnico rolnico changed the title Allow use of bus-breaker voltage levels and dangling lines Allow use of bus-breaker voltage levels Sep 26, 2024
@rolnico rolnico marked this pull request as ready for review September 26, 2024 08:00
Copy link

@rolnico rolnico requested a review from klorel September 27, 2024 07:45
@rolnico rolnico requested a review from jeandemanged November 7, 2024 13:50
Copy link

sonarqubecloud bot commented Nov 8, 2024

Copy link

sonarqubecloud bot commented Nov 8, 2024

Copy link
Member

@jeandemanged jeandemanged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me, thank you!

@rolnico rolnico merged commit edd3f0e into main Nov 8, 2024
13 checks passed
@rolnico rolnico deleted the nro/use_different_connectables branch November 8, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants