Skip to content

Conversation

@rolnico
Copy link
Member

@rolnico rolnico commented Oct 7, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?
No

What kind of change does this PR introduce?
Bug fix

What is the current behavior?
Artifact cannot anymore be uploaded with the release due to permission change on Github.

What is the new behavior (if this is a feature change)?
Add permission to the job in the CI.

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Other information:

@rolnico rolnico self-assigned this Oct 7, 2024
Signed-off-by: Nicolas Rol <[email protected]>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 7, 2024

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 7, 2024

Please retry analysis of this Pull-Request directly on SonarCloud

@rolnico
Copy link
Member Author

rolnico commented Dec 16, 2024

Covered by #178

@rolnico rolnico closed this Dec 16, 2024
@rolnico rolnico deleted the nro/fix_artifact_upload_in_CI branch January 27, 2025 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants