Add Windows CI #176

jeandemanged · 2024-10-09T16:31:49Z

Please check if the PR fulfills these requirements

The commit message follows our guidelines
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

No

What kind of change does this PR introduce?

Feature

What is the current behavior?

No windows CI

What is the new behavior (if this is a feature change)?
Add windows CI, including publishing of windows binaries on release

Does this PR introduce a breaking change or deprecate an API?

No

jeandemanged · 2024-10-09T19:46:53Z

metrix-simulator/cmake/tnr.cmake

 function(check_file file expected_file)
-    configure_file(${file} ${file} NEWLINE_STYLE LF) # required for windows ctest
-    execute_process( COMMAND ${CMAKE_COMMAND} -E compare_files ${file} ${expected_file}
+    execute_process( COMMAND ${CMAKE_COMMAND} -E compare_files --ignore-eol ${file} ${expected_file}


changed this way because previous code was assuming code was checked out using LF end of files, but this is not the default git behavior on Windows.

Note that --ignore-eol requires cmake 3.14+

jeandemanged · 2024-10-09T19:47:14Z

metrix-simulator/CMakeLists.txt


 if(MSVC)
-  add_compile_definitions(WIN32)
+  add_definitions(-D_WIN32_WINNT=0x0A00)


windows 10+

jeandemanged · 2024-10-09T19:48:04Z

metrix-simulator/CMakeLists.txt

 # 

-cmake_minimum_required(VERSION 3.12 FATAL_ERROR)
+cmake_minimum_required(VERSION 3.14 FATAL_ERROR)


For --ignore-eol option in tests, see metrix-simulator/cmake/tnr.cmake

jeandemanged · 2024-10-09T19:56:14Z

metrix-simulator/tests/variantes_regroupees/CMakeLists.txt


 if(METRIX_RUN_ALL_TESTS)
-metrix_test("variantes_regroupees_complexe" 11) # no check here because of random and equivalent solutions
+metrix_test_no_check("variantes_regroupees_complexe" 11) # no check here because of random and equivalent solutions


Note that the comment saying no check here because of random and equivalent solutions was already there...
On windows the results differ only in lines ordering.

well actually also happens on Ubuntu, but sporadically: https://github.com/powsybl/powsybl-metrix/actions/runs/11273050987/job/31349239541

jeandemanged · 2024-10-09T19:57:07Z

metrix-simulator/CMakeLists.txt

I am not really a cmake expert ... feedback welcome

Signed-off-by: Damien Jeandemange <[email protected]>

# Conflicts: # .github/workflows/release-ci.yml

Signed-off-by: Damien Jeandemange <[email protected]>

# Conflicts: # .github/old_workflows/ci_centos7.yml # .github/old_workflows/ci_ol8.yml # .github/old_workflows/ci_ubuntu.yml # .github/old_workflows/maven.yml # .github/old_workflows/qa_pr_cpp_centos7.yml # .github/old_workflows/qa_pr_cpp_ol8.yml # .github/old_workflows/qa_pr_cpp_ubuntu.yml # .github/workflows/dev-ci.yml # .github/workflows/full-ci.yml # .github/workflows/release-ci.yml

sonarqubecloud · 2024-11-07T14:25:15Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarqubecloud · 2024-11-07T14:32:20Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

rolnico

LGTM (and the CI worked)

* try rework github workflows Signed-off-by: Damien Jeandemange <[email protected]> * try rework github workflows Signed-off-by: Damien Jeandemange <[email protected]> * clang tidy Signed-off-by: Damien Jeandemange <[email protected]> * clang tidy Signed-off-by: Damien Jeandemange <[email protected]> * clang tidy Signed-off-by: Damien Jeandemange <[email protected]> * clang tidy Signed-off-by: Damien Jeandemange <[email protected]> * clang tidy Signed-off-by: Damien Jeandemange <[email protected]> * clang tidy Signed-off-by: Damien Jeandemange <[email protected]> * artifacts Signed-off-by: Damien Jeandemange <[email protected]> * artifacts Signed-off-by: Damien Jeandemange <[email protected]> * artifacts Signed-off-by: Damien Jeandemange <[email protected]> * artifacts Signed-off-by: Damien Jeandemange <[email protected]> * wip Signed-off-by: Damien Jeandemange <[email protected]> * fix Signed-off-by: Damien Jeandemange <[email protected]> * wip windows ci Signed-off-by: Damien Jeandemange <[email protected]> * wip windows ci Signed-off-by: Damien Jeandemange <[email protected]> * wip windows ci Signed-off-by: Damien Jeandemange <[email protected]> * wip windows ci / cpp tests Signed-off-by: Damien Jeandemange <[email protected]> * test Signed-off-by: Damien Jeandemange <[email protected]> * test Signed-off-by: Damien Jeandemange <[email protected]> * test Signed-off-by: Damien Jeandemange <[email protected]> * wip Signed-off-by: Damien Jeandemange <[email protected]> * fix Signed-off-by: Damien Jeandemange <[email protected]> * fix Signed-off-by: Damien Jeandemange <[email protected]> * fix Signed-off-by: Damien Jeandemange <[email protected]> * use softprops/action-gh-release Signed-off-by: Damien Jeandemange <[email protected]> * use softprops/action-gh-release Signed-off-by: Damien Jeandemange <[email protected]> * update readme for cmake 3.14 Signed-off-by: Damien Jeandemange <[email protected]> --------- Signed-off-by: Damien Jeandemange <[email protected]> Co-authored-by: Nicolas Rol <[email protected]> (cherry picked from commit 3c3943a)

* try rework github workflows Signed-off-by: Damien Jeandemange <[email protected]> * try rework github workflows Signed-off-by: Damien Jeandemange <[email protected]> * clang tidy Signed-off-by: Damien Jeandemange <[email protected]> * clang tidy Signed-off-by: Damien Jeandemange <[email protected]> * clang tidy Signed-off-by: Damien Jeandemange <[email protected]> * clang tidy Signed-off-by: Damien Jeandemange <[email protected]> * clang tidy Signed-off-by: Damien Jeandemange <[email protected]> * clang tidy Signed-off-by: Damien Jeandemange <[email protected]> * artifacts Signed-off-by: Damien Jeandemange <[email protected]> * artifacts Signed-off-by: Damien Jeandemange <[email protected]> * artifacts Signed-off-by: Damien Jeandemange <[email protected]> * artifacts Signed-off-by: Damien Jeandemange <[email protected]> * wip Signed-off-by: Damien Jeandemange <[email protected]> * fix Signed-off-by: Damien Jeandemange <[email protected]> * wip windows ci Signed-off-by: Damien Jeandemange <[email protected]> * wip windows ci Signed-off-by: Damien Jeandemange <[email protected]> * wip windows ci Signed-off-by: Damien Jeandemange <[email protected]> * wip windows ci / cpp tests Signed-off-by: Damien Jeandemange <[email protected]> * test Signed-off-by: Damien Jeandemange <[email protected]> * test Signed-off-by: Damien Jeandemange <[email protected]> * test Signed-off-by: Damien Jeandemange <[email protected]> * wip Signed-off-by: Damien Jeandemange <[email protected]> * fix Signed-off-by: Damien Jeandemange <[email protected]> * fix Signed-off-by: Damien Jeandemange <[email protected]> * fix Signed-off-by: Damien Jeandemange <[email protected]> * use softprops/action-gh-release Signed-off-by: Damien Jeandemange <[email protected]> * use softprops/action-gh-release Signed-off-by: Damien Jeandemange <[email protected]> * update readme for cmake 3.14 Signed-off-by: Damien Jeandemange <[email protected]> --------- Signed-off-by: Damien Jeandemange <[email protected]> Co-authored-by: Nicolas Rol <[email protected]>

jeandemanged self-assigned this Oct 9, 2024

jeandemanged commented Oct 9, 2024

View reviewed changes

jeandemanged added 22 commits October 15, 2024 19:49

try rework github workflows

3adc7df

Signed-off-by: Damien Jeandemange <[email protected]>

try rework github workflows

e89e73d

Signed-off-by: Damien Jeandemange <[email protected]>

clang tidy

73a8181

Signed-off-by: Damien Jeandemange <[email protected]>

clang tidy

d450945

Signed-off-by: Damien Jeandemange <[email protected]>

clang tidy

fc6491b

Signed-off-by: Damien Jeandemange <[email protected]>

clang tidy

cf78812

Signed-off-by: Damien Jeandemange <[email protected]>

clang tidy

e90f5cd

Signed-off-by: Damien Jeandemange <[email protected]>

clang tidy

ba6aa9f

Signed-off-by: Damien Jeandemange <[email protected]>

artifacts

0f32175

Signed-off-by: Damien Jeandemange <[email protected]>

artifacts

c13fbf2

Signed-off-by: Damien Jeandemange <[email protected]>

artifacts

3067cb0

Signed-off-by: Damien Jeandemange <[email protected]>

artifacts

723273b

Signed-off-by: Damien Jeandemange <[email protected]>

wip

a9528ad

Signed-off-by: Damien Jeandemange <[email protected]>

fix

b1c03be

Signed-off-by: Damien Jeandemange <[email protected]>

wip windows ci

4abfd50

Signed-off-by: Damien Jeandemange <[email protected]>

wip windows ci

f97ab3f

Signed-off-by: Damien Jeandemange <[email protected]>

wip windows ci

75c3322

Signed-off-by: Damien Jeandemange <[email protected]>

wip windows ci / cpp tests

8cec70e

Signed-off-by: Damien Jeandemange <[email protected]>

test

d6c0adf

Signed-off-by: Damien Jeandemange <[email protected]>

test

a0ceeb4

Signed-off-by: Damien Jeandemange <[email protected]>

test

ce49058

Signed-off-by: Damien Jeandemange <[email protected]>

wip

bc9a44c

Signed-off-by: Damien Jeandemange <[email protected]>

jeandemanged force-pushed the windows-ci branch from 6b6fea9 to bc9a44c Compare October 18, 2024 14:41

jeandemanged changed the base branch from main to gh-workflows October 18, 2024 14:42

jeandemanged added 4 commits October 28, 2024 16:55

Merge branch 'main' into gh-workflows

fbd0925

Merge branch 'gh-workflows' into windows-ci

8d38a0d

fix

8a26229

Signed-off-by: Damien Jeandemange <[email protected]>

fix

ca29d53

Signed-off-by: Damien Jeandemange <[email protected]>

jeandemanged added 7 commits October 28, 2024 21:40

fix

766fc14

Signed-off-by: Damien Jeandemange <[email protected]>

use softprops/action-gh-release

82bb2fb

Signed-off-by: Damien Jeandemange <[email protected]>

Merge branch 'refs/heads/gh-workflows' into windows-ci

497f497

# Conflicts: # .github/workflows/release-ci.yml

use softprops/action-gh-release

bb3f3c0

Signed-off-by: Damien Jeandemange <[email protected]>

Merge branch 'main' into gh-workflows

fa69197

Merge branch 'refs/heads/gh-workflows' into windows-ci

236122b

update readme for cmake 3.14

f1ea709

Signed-off-by: Damien Jeandemange <[email protected]>

Base automatically changed from gh-workflows to main November 7, 2024 13:38

jeandemanged and others added 2 commits November 7, 2024 14:44

Merge branch 'main' into windows-ci

985fb9a

jeandemanged changed the title ~~[WIP] Add Windows CI~~ Add Windows CI Nov 7, 2024

Merge branch 'main' into windows-ci

72bbc8c

rolnico approved these changes Nov 7, 2024

View reviewed changes

rolnico merged commit 3c3943a into main Nov 7, 2024
12 checks passed

rolnico deleted the windows-ci branch November 7, 2024 14:41

rolnico mentioned this pull request Jan 10, 2025

Add snapshot CI powsybl/powsybl-afs#166

Merged

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add Windows CI #176

Add Windows CI #176

Uh oh!

jeandemanged commented Oct 9, 2024

Uh oh!

jeandemanged Oct 9, 2024

Uh oh!

jeandemanged Oct 9, 2024

Uh oh!

jeandemanged Oct 9, 2024

Uh oh!

jeandemanged Oct 9, 2024

Uh oh!

jeandemanged Oct 10, 2024 •

edited

Loading

Uh oh!

jeandemanged Oct 9, 2024

Uh oh!

sonarqubecloud bot commented Nov 7, 2024

Uh oh!

sonarqubecloud bot commented Nov 7, 2024

Uh oh!

rolnico left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Add Windows CI #176

Add Windows CI #176

Uh oh!

Conversation

jeandemanged commented Oct 9, 2024

Uh oh!

jeandemanged Oct 9, 2024

Choose a reason for hiding this comment

Uh oh!

jeandemanged Oct 9, 2024

Choose a reason for hiding this comment

Uh oh!

jeandemanged Oct 9, 2024

Choose a reason for hiding this comment

Uh oh!

jeandemanged Oct 9, 2024

Choose a reason for hiding this comment

Uh oh!

jeandemanged Oct 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jeandemanged Oct 9, 2024

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Nov 7, 2024

Quality Gate passed

Uh oh!

sonarqubecloud bot commented Nov 7, 2024

Quality Gate passed

Uh oh!

rolnico left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jeandemanged Oct 10, 2024 •

edited

Loading