Refactor: consumption sign adjustments#246
Open
lamoletoscar wants to merge 3 commits intopowsybl:mainfrom
Open
Refactor: consumption sign adjustments#246lamoletoscar wants to merge 3 commits intopowsybl:mainfrom
lamoletoscar wants to merge 3 commits intopowsybl:mainfrom
Conversation
Signed-off-by: lamoletoscar <lamoletoscar@proton.me>
Signed-off-by: lamoletoscar <lamoletoscar@proton.me>
klorel
reviewed
Nov 21, 2025
klorel
approved these changes
Nov 21, 2025
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
Refactor an output and docs update.
What is the current behavior?
In the metrix-simulator output, in the results tables, the values describing preventive load shedding are positive, whereas they are negative for corrective load shedding.
What is the new behavior (if this is a feature change)?
In the output from metrix-simulator, in the results tables, the values describing preventive and corrective load shedding have the same sign (positive).
Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
The values in the R1B table are now positive. Be careful if you use them directly to change how you handle them.
Other information:
This PR modifies the metrix-simulator part. For the rest (i.e., how metrix-simulator outputs are used in the Java code), it is necessary to check whether any changes need to be made. The metrix-simulator documentation has already been updated to reflect the change introduced by this PR ("docs/simulator/io_doc.md"). Once everything else is OK, the "DOC.md" file will also need to be updated. In addition, the signs of the values in the R1B table in the files “metrix-integration/src/test/resources/result_s10” and “metrix-integration/src/test/resources/result_s12” will also need to be modified in order to perform the tests on the Java side.