Skip to content

Comments

Add batteries in the Java sections#247

Draft
MatthieuSAUR wants to merge 19 commits intomainfrom
msa/feature/battery_java
Draft

Add batteries in the Java sections#247
MatthieuSAUR wants to merge 19 commits intomainfrom
msa/feature/battery_java

Conversation

@MatthieuSAUR
Copy link
Contributor

@MatthieuSAUR MatthieuSAUR commented Nov 6, 2025 •
edited
Loading

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • A PR or issue has been opened in all impacted repositories (if any)

Does this PR already have an issue describing the problem?

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Other information:

@MatthieuSAUR MatthieuSAUR force-pushed the msa/feature/battery_java branch 2 times, most recently from b5d6da2 to 01db238 Compare November 10, 2025 16:36
@MatthieuSAUR MatthieuSAUR force-pushed the msa/feature/battery_java branch from 1a64021 to 60630f9 Compare November 26, 2025 11:53
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 26, 2025

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
86.9% Coverage on New Code
0.3% Duplication on New Code

See analysis details on SonarQube Cloud

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 26, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
68.9% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@MatthieuSAUR MatthieuSAUR force-pushed the msa/feature/battery_java branch 2 times, most recently from 3d91f8e to a173f7e Compare December 12, 2025 09:46
@MatthieuSAUR
[Battery] Add batteries into java (init WIP)
7c77620 
Signed-off-by: Matthieu SAUR <matthieu.saur@rte-france.com>
@MatthieuSAUR
[Battery] Add batteries into java (add mapToBatteryVariable())
edbd27a 
Signed-off-by: Matthieu SAUR <matthieu.saur@rte-france.com>
@MatthieuSAUR
[Battery] Fix Rebase main
3ebbfa2 
Signed-off-by: Matthieu SAUR <matthieu.saur@rte-france.com>
@MatthieuSAUR
[Battery] Add mapToBatteries
0ff87bd 
Signed-off-by: Matthieu SAUR <matthieu.saur@rte-france.com>
@MatthieuSAUR
[Battery] Add UT and missing json field name
c2d0969 
Signed-off-by: Matthieu SAUR <matthieu.saur@rte-france.com>
@MatthieuSAUR
[Battery] Add batteryToMinValues and batteryToMaxValues
c392328 
Signed-off-by: Matthieu SAUR <matthieu.saur@rte-france.com>
@MatthieuSAUR
[Battery] Fixed bad copy/paste on getNotMappedEquipmentTimeSeriesKeys()
8f8608d 
Signed-off-by: Matthieu SAUR <matthieu.saur@rte-france.com>
@MatthieuSAUR
[Battery] Add NetworkPointWriter UT
eee88fb 
Signed-off-by: Matthieu SAUR <matthieu.saur@rte-france.com>
@MatthieuSAUR
[Battery] Adding BatteryBoundLimitBuilder and UT
97a0d40 
(WIP missing unit test)

Signed-off-by: Matthieu SAUR <matthieu.saur@rte-france.com>
@MatthieuSAUR
[Battery] Adding BatteryBoundLimitBuilder and UT
5458a78 
(WIP missing unit test)

Signed-off-by: Matthieu SAUR <matthieu.saur@rte-france.com>
@MatthieuSAUR
[Battery] Adding missing max,min and P getter and UT
edddfec 
(WIP missing unit test)

Signed-off-by: Matthieu SAUR <matthieu.saur@rte-france.com>
@MatthieuSAUR
[Battery] Adding Unit test on TimeSeriesMapperChecker
15d8115 
(WIP missing unit test)

Signed-off-by: Matthieu SAUR <matthieu.saur@rte-france.com>
@MatthieuSAUR
[Battery] Adding MetrixBatteriesBinding and groovy data and binding f…
110a693 
…or batteries

(WIP missing unit test)

Signed-off-by: Matthieu SAUR <matthieu.saur@rte-france.com>
@MatthieuSAUR
[Battery] Fix readR2D, readR7, readR9
bd7f21a 
Signed-off-by: Matthieu SAUR <matthieu.saur@rte-france.com>
@MatthieuSAUR
[Battery] Adding isHeader method and constants
3372b35 
Signed-off-by: Matthieu SAUR <matthieu.saur@rte-france.com>
@MatthieuSAUR
[Battery] Adding constant
4cf4d54 
Signed-off-by: Matthieu SAUR <matthieu.saur@rte-france.com>
@MatthieuSAUR
[Battery] Fix duplicated code
32ab6e5 
Signed-off-by: Matthieu SAUR <matthieu.saur@rte-france.com>
@MatthieuSAUR
[Battery] Adding missing battery Method
2c22724 
Signed-off-by: Matthieu SAUR <matthieu.saur@rte-france.com>
@MatthieuSAUR
[Battery] Add BatteryDslData
5526aec 
Signed-off-by: Matthieu SAUR <matthieu.saur@rte-france.com>
@MatthieuSAUR MatthieuSAUR force-pushed the msa/feature/battery_java branch from a173f7e to 5526aec Compare December 12, 2025 09:48
@rolnico rolnico changed the title battery Add batteries in the Java sections Jan 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marifunf marifunf marifunf left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MatthieuSAUR @marifunf