fix: use dir path instead of file path in cleanup method #234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KoloMenek
force-pushed
the
fix/GRD-3583
branch
2 times, most recently
from
aecdb82 to
c5bb101
Compare
KoloMenek
changed the title
etiennehomer
requested changes
Dec 12, 2025
src/test/java/com/powsybl/network/conversion/server/NetworkConversionTest.java
Show resolved
Hide resolved
src/test/java/com/powsybl/network/conversion/server/NetworkConversionTest.java
Outdated
Show resolved
Hide resolved
KoloMenek
force-pushed
the
fix/GRD-3583
branch
2 times, most recently
from
4ceeceb to
780da4f
Compare
Signed-off-by: Kamil MARUT <[email protected]>
KoloMenek
force-pushed
the
fix/GRD-3583
branch
from
780da4f to
47290c9
Compare
etiennehomer
approved these changes
Dec 12, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
What kind of change does this PR introduce?
bug fix
What is the current behavior?
When an error occurs in the getExportNetworkInfos() method, the cleanup method will try to delete the parent of the tempDir which is /tmp.
What is the new behavior (if this is a feature change)?
Now, every call to the cleanup method will be using the path of the directory we want to delete.
Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
Other information: