-
Notifications
You must be signed in to change notification settings - Fork 1
Upgrade to powsybl-dependencies v2025.0.1 #115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: BOUTIER Charly <[email protected]>
…pgrade Signed-off-by: Etienne LESOT <[email protected]>
Signed-off-by: Etienne LESOT <[email protected]>
network-store-iidm-tck/src/test/java/com/powsybl/network/store/tck/AreaIt.java
Outdated
Show resolved
Hide resolved
network-store-iidm-tck/src/test/java/com/powsybl/network/store/tck/AreaIt.java
Outdated
Show resolved
Hide resolved
network-store-iidm-tck/src/test/java/com/powsybl/network/store/tck/AreaIt.java
Outdated
Show resolved
Hide resolved
network-store-iidm-tck/src/test/java/com/powsybl/network/store/tck/AreaIt.java
Outdated
Show resolved
Hide resolved
network-store-iidm-tck/src/test/java/com/powsybl/network/store/tck/AreaIt.java
Outdated
Show resolved
Hide resolved
...ore-integration-test/src/test/java/com/powsybl/network/store/integration/NetworkStoreIT.java
Outdated
Show resolved
Hide resolved
...ore-integration-test/src/test/java/com/powsybl/network/store/integration/NetworkStoreIT.java
Outdated
Show resolved
Hide resolved
network-store-server/src/main/resources/db/changelog/changesets/changelog_20250415T064500Z.xml
Show resolved
Hide resolved
network-store-server/src/main/resources/db/changelog/changesets/changelog_20250415T064500Z.xml
Outdated
Show resolved
Hide resolved
network-store-server/src/main/resources/db/changelog/changesets/changelog_20250415T064500Z.xml
Show resolved
Hide resolved
network-store-server/src/main/java/com/powsybl/network/store/server/NetworkStoreController.java
Show resolved
Hide resolved
...er/src/main/resources/db/changelog/changesets/migrationCgmesControlArea_20250415T120000Z.sql
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I got the following error when testing short circuit analysis :
java.lang.NoClassDefFoundError: com/powsybl/iidm/network/extensions/ShortCircuitExtension
at java.base/java.lang.ClassLoader.defineClass1(Native Method) ~[na:na]
at java.base/java.lang.ClassLoader.defineClass(ClassLoader.java:1027) ~[na:na]
at java.base/java.security.SecureClassLoader.defineClass(SecureClassLoader.java:150) ~[na:na]
at java.base/jdk.internal.loader.BuiltinClassLoader.defineClass(BuiltinClassLoader.java:862) ~[na:na]
at java.base/jdk.internal.loader.BuiltinClassLoader.findClassOnClassPathOrNull(BuiltinClassLoader.java:760) ~[na:na]
at java.base/jdk.internal.loader.BuiltinClassLoader.loadClassOrNull(BuiltinClassLoader.java:681) ~[na:na]
at java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:639) ~[na:na]
at java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:188) ~[na:na]
at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:526) ~[na:na]
at java.base/java.lang.ClassLoader.defineClass1(Native Method) ~[na:na]
at java.base/java.lang.ClassLoader.defineClass(ClassLoader.java:1027) ~[na:na]
at java.base/java.security.SecureClassLoader.defineClass(SecureClassLoader.java:150) ~[na:na]
at java.base/jdk.internal.loader.BuiltinClassLoader.defineClass(BuiltinClassLoader.java:862) ~[na:na]
at java.base/jdk.internal.loader.BuiltinClassLoader.findClassOnClassPathOrNull(BuiltinClassLoader.java:760) ~[na:na]
at java.base/jdk.internal.loader.BuiltinClassLoader.loadClassOrNull(BuiltinClassLoader.java:681) ~[na:na]
at java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:639) ~[na:na]
at java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:188) ~[na:na]
at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:526) ~[na:na]
at com.powsybl.network.store.iidm.impl.GeneratorImpl.createGeneratorShortCircuitExtension(GeneratorImpl.java:264) ~[powsybl-network-store-iidm-impl-1.25.0-SNAPSHOT.jar:na]
at com.powsybl.network.store.iidm.impl.GeneratorImpl.getExtension(GeneratorImpl.java:289) ~[powsybl-network-store-iidm-impl-1.25.0-SNAPSHOT.jar:na]
In this code :
private <E extends Extension<Generator>> E createGeneratorShortCircuitExtension() {
E extension = null;
var resource = getResource();
ShortCircuitAttributes attributes = resource.getAttributes().getGeneratorShortCircuitAttributes();
if (attributes != null) {
extension = (E) new GeneratorShortCircuitImpl((GeneratorImpl) getInjection());
}
return extension;
}
But I had so many problems because of dependecy errors that I am not sure of anything. Just make sure that Charly tests short circuit analysis when he does the final merge.
Yes it's not so easy to test the whole chain. I could import a PF with success and check the battery short circuit extension in the database. I also ran a shortcircuit computation and the batteries were taken in account in the computation ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't manage to test the conversion server because of dependencies problems. Therefore I was missing area data when creating a study from a cgmes case.
Just like short circuit computation, it should be tested again during the final merge.
Otherwise, test and code ok for me.
...ation-test/src/test/java/com/powsybl/network/store/integration/NetworkStoreExtensionsIT.java
Outdated
Show resolved
Hide resolved
network-store-server/src/main/java/com/powsybl/network/store/server/Mappings.java
Outdated
Show resolved
Hide resolved
network-store-server/src/main/java/com/powsybl/network/store/server/NetworkStoreController.java
Outdated
Show resolved
Hide resolved
network-store-server/src/main/java/com/powsybl/network/store/server/NetworkStoreController.java
Outdated
Show resolved
Hide resolved
network-store-server/src/main/java/com/powsybl/network/store/server/NetworkStoreController.java
Outdated
Show resolved
Hide resolved
network-store-server/src/main/java/com/powsybl/network/store/server/QueryCatalog.java
Outdated
Show resolved
Hide resolved
network-store-server/src/main/java/com/powsybl/network/store/server/QueryCatalog.java
Outdated
Show resolved
Hide resolved
network-store-server/src/main/java/com/powsybl/network/store/server/NetworkStoreRepository.java
Outdated
Show resolved
Hide resolved
network-store-server/src/main/java/com/powsybl/network/store/server/NetworkStoreRepository.java
Show resolved
Hide resolved
network-store-server/src/main/java/com/powsybl/network/store/server/NetworkStoreRepository.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Etienne LESOT <[email protected]>
Signed-off-by: Etienne LESOT <[email protected]>
Signed-off-by: Etienne LESOT <[email protected]>
Signed-off-by: BOUTIER Charly <[email protected]>
Signed-off-by: Etienne LESOT <[email protected]>
Signed-off-by: Etienne LESOT <[email protected]>
network-store-server/src/main/java/com/powsybl/network/store/server/NetworkStoreRepository.java
Outdated
Show resolved
Hide resolved
...ation-test/src/test/java/com/powsybl/network/store/integration/NetworkStoreExtensionsIT.java
Show resolved
Hide resolved
network-store-server/src/main/java/com/powsybl/network/store/server/QueryCatalog.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Etienne LESOT <[email protected]>
Signed-off-by: BOUHOURS Antoine <[email protected]>
Signed-off-by: Etienne LESOT <[email protected]>
Signed-off-by: Etienne LESOT <[email protected]>
Signed-off-by: Etienne LESOT <[email protected]>
Signed-off-by: Etienne LESOT <[email protected]>
Signed-off-by: Etienne LESOT <[email protected]>
|
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
Other information: