Skip to content

Upgrade to powsybl-dependencies v2025.0.1 #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
May 16, 2025

Conversation

EstherDarkish
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • A PR or issue has been opened in all impacted repositories (if any)

Does this PR already have an issue describing the problem?

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Other information:

@Mathieu-Deharbe Mathieu-Deharbe self-requested a review April 18, 2025 07:14
@etiennehomer etiennehomer self-requested a review April 18, 2025 07:20
Signed-off-by: Etienne LESOT <[email protected]>
Copy link
Contributor

@Mathieu-Deharbe Mathieu-Deharbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got the following error when testing short circuit analysis :

java.lang.NoClassDefFoundError: com/powsybl/iidm/network/extensions/ShortCircuitExtension
at java.base/java.lang.ClassLoader.defineClass1(Native Method) ~[na:na]
at java.base/java.lang.ClassLoader.defineClass(ClassLoader.java:1027) ~[na:na]
at java.base/java.security.SecureClassLoader.defineClass(SecureClassLoader.java:150) ~[na:na]
at java.base/jdk.internal.loader.BuiltinClassLoader.defineClass(BuiltinClassLoader.java:862) ~[na:na]
at java.base/jdk.internal.loader.BuiltinClassLoader.findClassOnClassPathOrNull(BuiltinClassLoader.java:760) ~[na:na]
at java.base/jdk.internal.loader.BuiltinClassLoader.loadClassOrNull(BuiltinClassLoader.java:681) ~[na:na]
at java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:639) ~[na:na]
at java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:188) ~[na:na]
at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:526) ~[na:na]
at java.base/java.lang.ClassLoader.defineClass1(Native Method) ~[na:na]
at java.base/java.lang.ClassLoader.defineClass(ClassLoader.java:1027) ~[na:na]
at java.base/java.security.SecureClassLoader.defineClass(SecureClassLoader.java:150) ~[na:na]
at java.base/jdk.internal.loader.BuiltinClassLoader.defineClass(BuiltinClassLoader.java:862) ~[na:na]
at java.base/jdk.internal.loader.BuiltinClassLoader.findClassOnClassPathOrNull(BuiltinClassLoader.java:760) ~[na:na]
at java.base/jdk.internal.loader.BuiltinClassLoader.loadClassOrNull(BuiltinClassLoader.java:681) ~[na:na]
at java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:639) ~[na:na]
at java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:188) ~[na:na]
at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:526) ~[na:na]
at com.powsybl.network.store.iidm.impl.GeneratorImpl.createGeneratorShortCircuitExtension(GeneratorImpl.java:264) ~[powsybl-network-store-iidm-impl-1.25.0-SNAPSHOT.jar:na]
at com.powsybl.network.store.iidm.impl.GeneratorImpl.getExtension(GeneratorImpl.java:289) ~[powsybl-network-store-iidm-impl-1.25.0-SNAPSHOT.jar:na]

In this code :

private <E extends Extension<Generator>> E createGeneratorShortCircuitExtension() {
        E extension = null;
        var resource = getResource();
        ShortCircuitAttributes attributes = resource.getAttributes().getGeneratorShortCircuitAttributes();
        if (attributes != null) {
            extension = (E) new GeneratorShortCircuitImpl((GeneratorImpl) getInjection());
        }
        return extension;
    }

But I had so many problems because of dependecy errors that I am not sure of anything. Just make sure that Charly tests short circuit analysis when he does the final merge.

@etiennehomer
Copy link
Collaborator

I got the following error when testing short circuit analysis :

java.lang.NoClassDefFoundError: com/powsybl/iidm/network/extensions/ShortCircuitExtension at java.base/java.lang.ClassLoader.defineClass1(Native Method) ~[na:na] at java.base/java.lang.ClassLoader.defineClass(ClassLoader.java:1027) ~[na:na] at java.base/java.security.SecureClassLoader.defineClass(SecureClassLoader.java:150) ~[na:na] at java.base/jdk.internal.loader.BuiltinClassLoader.defineClass(BuiltinClassLoader.java:862) ~[na:na] at java.base/jdk.internal.loader.BuiltinClassLoader.findClassOnClassPathOrNull(BuiltinClassLoader.java:760) ~[na:na] at java.base/jdk.internal.loader.BuiltinClassLoader.loadClassOrNull(BuiltinClassLoader.java:681) ~[na:na] at java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:639) ~[na:na] at java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:188) ~[na:na] at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:526) ~[na:na] at java.base/java.lang.ClassLoader.defineClass1(Native Method) ~[na:na] at java.base/java.lang.ClassLoader.defineClass(ClassLoader.java:1027) ~[na:na] at java.base/java.security.SecureClassLoader.defineClass(SecureClassLoader.java:150) ~[na:na] at java.base/jdk.internal.loader.BuiltinClassLoader.defineClass(BuiltinClassLoader.java:862) ~[na:na] at java.base/jdk.internal.loader.BuiltinClassLoader.findClassOnClassPathOrNull(BuiltinClassLoader.java:760) ~[na:na] at java.base/jdk.internal.loader.BuiltinClassLoader.loadClassOrNull(BuiltinClassLoader.java:681) ~[na:na] at java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:639) ~[na:na] at java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:188) ~[na:na] at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:526) ~[na:na] at com.powsybl.network.store.iidm.impl.GeneratorImpl.createGeneratorShortCircuitExtension(GeneratorImpl.java:264) ~[powsybl-network-store-iidm-impl-1.25.0-SNAPSHOT.jar:na] at com.powsybl.network.store.iidm.impl.GeneratorImpl.getExtension(GeneratorImpl.java:289) ~[powsybl-network-store-iidm-impl-1.25.0-SNAPSHOT.jar:na]

In this code :

private <E extends Extension<Generator>> E createGeneratorShortCircuitExtension() {
        E extension = null;
        var resource = getResource();
        ShortCircuitAttributes attributes = resource.getAttributes().getGeneratorShortCircuitAttributes();
        if (attributes != null) {
            extension = (E) new GeneratorShortCircuitImpl((GeneratorImpl) getInjection());
        }
        return extension;
    }

But I had so many problems because of dependecy errors that I am not sure of anything. Just make sure that Charly tests short circuit analysis when he does the final merge.

Yes it's not so easy to test the whole chain. I could import a PF with success and check the battery short circuit extension in the database. I also ran a shortcircuit computation and the batteries were taken in account in the computation !

Copy link
Contributor

@Mathieu-Deharbe Mathieu-Deharbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't manage to test the conversion server because of dependencies problems. Therefore I was missing area data when creating a study from a cgmes case.

Just like short circuit computation, it should be tested again during the final merge.

Otherwise, test and code ok for me.

Signed-off-by: Etienne LESOT <[email protected]>
EtienneLt and others added 6 commits April 28, 2025 14:23
Signed-off-by: Etienne LESOT <[email protected]>
Signed-off-by: Etienne LESOT <[email protected]>
Signed-off-by: BOUTIER Charly <[email protected]>
Signed-off-by: Etienne LESOT <[email protected]>
Signed-off-by: Etienne LESOT <[email protected]>
@EtienneLt EtienneLt changed the title Upgrade to powsybl-dependencies v2025.0.0 Upgrade to powsybl-dependencies v2025.0.1 May 15, 2025
EtienneLt and others added 4 commits May 15, 2025 09:22
Signed-off-by: Etienne LESOT <[email protected]>
Signed-off-by: BOUHOURS Antoine <[email protected]>
Signed-off-by: Etienne LESOT <[email protected]>
Signed-off-by: Etienne LESOT <[email protected]>
EtienneLt added 3 commits May 15, 2025 13:52
Signed-off-by: Etienne LESOT <[email protected]>
Signed-off-by: Etienne LESOT <[email protected]>
Signed-off-by: Etienne LESOT <[email protected]>
Copy link

@EtienneLt EtienneLt self-assigned this May 16, 2025
@jonenst jonenst merged commit 28d2a93 into main May 16, 2025
5 checks passed
@jonenst jonenst deleted the upgrade_to_powsybl_dependencies_2025.0.0 branch May 16, 2025 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants