Complete persistent iidm implementation #163

SlimaneAmar · 2020-12-11T15:59:05Z

Please check if the PR fulfills these requirements (please use '[x]' to check the checkboxes, or submit the PR and then click the checkboxes)

The commit message follows our guidelines
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem ? If so, link to this issue using '#XXX' and skip the rest

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API? If yes, check the following:

The Breaking Change or Deprecated label has been added
The migration guide has been updated in the github wiki (What changes might users need to make in their application due to this PR?)

Other information:

(if any of the questions/checkboxes don't apply, please delete them entirely)

Signed-off-by: Slimane AMAR <[email protected]>

…rminals (#162) Signed-off-by: Slimane AMAR <[email protected]>

Signed-off-by: Slimane AMAR <[email protected]>

…163) Signed-off-by: Slimane AMAR <[email protected]>

Signed-off-by: Slimane AMAR <[email protected]>

…163) Signed-off-by: Slimane AMAR <[email protected]>

Signed-off-by: Slimane AMAR <[email protected]>

…merged and configured) (#163) Signed-off-by: Slimane AMAR <[email protected]>

Signed-off-by: Slimane AMAR <[email protected]>

…breaker topology (#163) Signed-off-by: Slimane AMAR <[email protected]>

Signed-off-by: Slimane AMAR <[email protected]>

…mically created on the fly from attributes (#163) Signed-off-by: Slimane AMAR <[email protected]>

Signed-off-by: Slimane AMAR <[email protected]>

network-store-iidm-impl/src/main/java/com/powsybl/network/store/iidm/impl/VoltageLevelImpl.java

Signed-off-by: Slimane AMAR <[email protected]>

…tore into complete_persistent_iidm_implementation

geofjamg · 2021-02-08T10:57:06Z

...k-store-iidm-impl/src/main/java/com/powsybl/network/store/iidm/impl/NodeBreakerViewImpl.java


-        Graph<Integer, Edge> graph = NodeBreakerTopology.INSTANCE.buildGraph(index, voltageLevelResource);
+        Graph<Integer, Edge> graph = NodeBreakerTopology.INSTANCE.buildGraph(index, voltageLevelResource, true, true);


Why is this method called with isBusView to true. What is the purpose of this option?

The connectivity graph is used to calculate buses in a VL and in node/breaker the calculated buses depends on the chosen view.
BusView : !switch::isOpen
BusBreakerView : !switch::isOpen && !switch::isRetained
But when we just traverse the topology, we do not take into account the switches (open or retained).

Maybe i need rename isBusView by includeRetainedSwitches

geofjamg · 2021-02-08T11:56:37Z

network-store-iidm-impl/src/main/java/com/powsybl/network/store/iidm/impl/HvdcLineImpl.java

    }

    @Override
    public void remove() {
+        resource.getAttributes().setConverterStationId1(null);


Why do yu need to change the resource as it won't be used anymore?

I agree but the tck test AbstractLccTest::testHvdcLineRemove considers that it must be set to null and checks it

geofjamg · 2021-02-08T11:58:32Z

network-store-iidm-impl/src/main/java/com/powsybl/network/store/iidm/impl/HvdcLineImpl.java

@@ -27,16 +27,19 @@ static HvdcLineImpl create(NetworkObjectIndex index, Resource<HvdcLineAttributes

    @Override
    public HvdcConverterStation<?> getConverterStation1() {
-        return index.getHvdcConverterStation(resource.getAttributes().getConverterStationId1()).orElseThrow(IllegalStateException::new);
+        return resource.getAttributes().getConverterStationId1() != null ? index.getHvdcConverterStation(resource.getAttributes().getConverterStationId1()).orElse(null) : null;


Is should not be possible to have this null

See comment above

geofjamg · 2021-02-08T11:58:37Z

network-store-iidm-impl/src/main/java/com/powsybl/network/store/iidm/impl/HvdcLineImpl.java

    }

    @Override
    public HvdcConverterStation<?> getConverterStation2() {
-        return index.getHvdcConverterStation(resource.getAttributes().getConverterStationId2()).orElseThrow(IllegalStateException::new);
+        return resource.getAttributes().getConverterStationId2() != null ? index.getHvdcConverterStation(resource.getAttributes().getConverterStationId2()).orElse(null) : null;


see comment above

geofjamg · 2021-02-08T12:00:58Z

network-store-iidm-impl/src/main/java/com/powsybl/network/store/iidm/impl/NetworkImpl.java

-        public Collection<Component> getConnectedComponents() {
-            throw new UnsupportedOperationException("TODO");
+        public Collection<Component> getConnectedComponents() { // FIXME : need a reference bus by component
+            return getBusStream().map(Bus::getConnectedComponent).collect(Collectors.toList());


This is not correct, as you are going to have here as many ConnectedComponent object as Bus but the aim was to get a list of unique ConnectedComponent

…or optimization purposes (#163) Signed-off-by: Slimane AMAR <[email protected]>

…tore into complete_persistent_iidm_implementation

# Conflicts: # network-store-server/src/main/java/com/powsybl/network/store/server/NetworkStoreRepository.java # network-store-server/src/main/resources/iidm.cql

Signed-off-by: Geoffroy Jamgotchian <[email protected]>

sonarqubecloud · 2021-02-09T13:30:21Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
33 Code Smells

85.4% Coverage
0.4% Duplication

SlimaneAmar added 4 commits December 11, 2020 13:32

Implement the topology traverser for a terminal (#162)

0cdaeed

Signed-off-by: Slimane AMAR <[email protected]>

Add a unit test (#162)

3246b9a

Signed-off-by: Slimane AMAR <[email protected]>

Fix when the connectable of the initial terminal has other (sides) te…

c00fb23

…rminals (#162) Signed-off-by: Slimane AMAR <[email protected]>

Add a unit test for node/breaker VL (#162

d42e9ca

Signed-off-by: Slimane AMAR <[email protected]>

SlimaneAmar added a commit that referenced this pull request Dec 11, 2020

Merged buses implementation (#163)

5bcc0ce

Signed-off-by: Slimane AMAR <[email protected]>

SlimaneAmar requested a review from geofjamg December 11, 2020 16:01

SlimaneAmar pushed a commit that referenced this pull request Dec 17, 2020

Complete implementation bus view and bus/breaker view (#163)

de0f761

Signed-off-by: Slimane AMAR <[email protected]>

SlimaneAmar force-pushed the complete_persistent_iidm_implementation branch from 5bcc0ce to de0f761 Compare December 17, 2020 08:31

SlimaneAmar added a commit that referenced this pull request Dec 17, 2020

Improve test coverage (#163)

b0b3745

Signed-off-by: Slimane AMAR <[email protected]>

SlimaneAmar added a commit that referenced this pull request Dec 21, 2020

Complete implementation bus view and bus/breaker view for terminals (#…

04da2ad

…163) Signed-off-by: Slimane AMAR <[email protected]>

geofjamg and others added 4 commits December 21, 2020 11:23

Complete implementation bus view and bus/breaker view for VLs (#163)

08816ed

Signed-off-by: Slimane AMAR <[email protected]>

Improve test coverage (#163)

579c19a

Signed-off-by: Slimane AMAR <[email protected]>

Complete implementation bus view and bus/breaker view for terminals (#…

f886996

…163) Signed-off-by: Slimane AMAR <[email protected]>

Improve test coverage (#163)

331a6e5

Signed-off-by: Slimane AMAR <[email protected]>

SlimaneAmar force-pushed the complete_persistent_iidm_implementation branch from 04da2ad to 331a6e5 Compare December 21, 2020 11:59

SlimaneAmar added a commit that referenced this pull request Dec 21, 2020

Add some (node or bus) checks for AbstractInjectionAdder (#163)

f2dc293

Signed-off-by: Slimane AMAR <[email protected]>

SlimaneAmar added a commit that referenced this pull request Dec 21, 2020

Add some (node or bus) checks for AbstractInjectionAdder (#163)

b897899

Signed-off-by: Slimane AMAR <[email protected]>

SlimaneAmar force-pushed the complete_persistent_iidm_implementation branch from f2dc293 to b897899 Compare December 21, 2020 17:25

Add some (node or bus) checks for AbstractInjectionAdder (#163)

8283cab

Signed-off-by: Slimane AMAR <[email protected]>

SlimaneAmar force-pushed the complete_persistent_iidm_implementation branch from b897899 to 8283cab Compare December 21, 2020 17:45

Force a buses recalculation when the view change (#163)

90eaf8e

Signed-off-by: Slimane AMAR <[email protected]>

SlimaneAmar added a commit that referenced this pull request Dec 23, 2020

Deduce the calculated bus id in the node/breaker topology (#163)

0791533

Signed-off-by: Slimane AMAR <[email protected]>

Deduce the calculated bus id in the node/breaker topology (#163)

7e339f0

Signed-off-by: Slimane AMAR <[email protected]>

SlimaneAmar force-pushed the complete_persistent_iidm_implementation branch from 0791533 to 7e339f0 Compare December 23, 2020 11:40

SlimaneAmar added 5 commits December 24, 2020 19:30

Implement connected and connectable terminals for buses (calculated, …

5658a54

…merged and configured) (#163) Signed-off-by: Slimane AMAR <[email protected]>

Add a unit test for equipments visitor from a bus (#163)

7d0557d

Signed-off-by: Slimane AMAR <[email protected]>

Implement the connectable bus search for a terminal bus view in node/…

32cbb49

…breaker topology (#163) Signed-off-by: Slimane AMAR <[email protected]>

Fix for topology traversal of internal connections (#163)

7153a96

Signed-off-by: Slimane AMAR <[email protected]>

P and Q calculation for buses (#163)

f0b75d0

Signed-off-by: Slimane AMAR <[email protected]>

SlimaneAmar added a commit that referenced this pull request Dec 30, 2020

CurrentLimits, RatioTapChanger and PhaseTapChanger are no longer dyna…

1c9daaf

…mically created on the fly from attributes (#163) Signed-off-by: Slimane AMAR <[email protected]>

SlimaneAmar force-pushed the complete_persistent_iidm_implementation branch from 19906aa to 9544d1c Compare February 4, 2021 18:11

SlimaneAmar requested a review from niconoir February 5, 2021 11:10

SlimaneAmar added a commit that referenced this pull request Feb 5, 2021

Review remarks (#163)

7ed5216

Signed-off-by: Slimane AMAR <[email protected]>

Review remarks (#163)

d9b92ff

Signed-off-by: Slimane AMAR <[email protected]>

SlimaneAmar force-pushed the complete_persistent_iidm_implementation branch from 7ed5216 to d9b92ff Compare February 5, 2021 12:29

SlimaneAmar added a commit that referenced this pull request Feb 5, 2021

Improve test coverage (#163)

2b0c3db

Signed-off-by: Slimane AMAR <[email protected]>

niconoir approved these changes Feb 5, 2021

View reviewed changes

SlimaneAmar added a commit that referenced this pull request Feb 5, 2021

Improve test coverage (#163)

15b0312

Signed-off-by: Slimane AMAR <[email protected]>

SlimaneAmar force-pushed the complete_persistent_iidm_implementation branch from 2b0c3db to 15b0312 Compare February 5, 2021 17:18

niconoir suggested changes Feb 5, 2021

View reviewed changes

network-store-iidm-impl/src/main/java/com/powsybl/network/store/iidm/impl/VoltageLevelImpl.java Show resolved Hide resolved

SlimaneAmar added a commit that referenced this pull request Feb 5, 2021

Improve test coverage (#163)

3b49ed6

Signed-off-by: Slimane AMAR <[email protected]>

SlimaneAmar force-pushed the complete_persistent_iidm_implementation branch from 15b0312 to 3b49ed6 Compare February 5, 2021 19:15

Improve test coverage (#163)

2a684ba

Signed-off-by: Slimane AMAR <[email protected]>

SlimaneAmar force-pushed the complete_persistent_iidm_implementation branch from 3b49ed6 to 2a684ba Compare February 8, 2021 07:47

SlimaneAmar requested a review from niconoir February 8, 2021 07:47

niconoir approved these changes Feb 8, 2021

View reviewed changes

Merge branch 'master' of https://github.com/powsybl/powsybl-network-s…

4c9ee77

…tore into complete_persistent_iidm_implementation

geofjamg requested changes Feb 8, 2021

View reviewed changes

Separation of the calculated bus cache for bus and busBreaker views f…

af29586

…or optimization purposes (#163) Signed-off-by: Slimane AMAR <[email protected]>

SlimaneAmar force-pushed the complete_persistent_iidm_implementation branch from 6d28ea0 to 772a17d Compare February 9, 2021 11:56

Merge branch 'master' of https://github.com/powsybl/powsybl-network-s…

a0fb7f9

…tore into complete_persistent_iidm_implementation

SlimaneAmar force-pushed the complete_persistent_iidm_implementation branch from 772a17d to a0fb7f9 Compare February 9, 2021 12:08

SlimaneAmar requested a review from geofjamg February 9, 2021 12:21

SlimaneAmar changed the title ~~[WIP] Complete persistent iidm implementation~~ Complete persistent iidm implementation Feb 9, 2021

geofjamg added 2 commits February 9, 2021 13:58

Merge branch 'master' into complete_persistent_iidm_implementation

bb2d927

# Conflicts: # network-store-server/src/main/java/com/powsybl/network/store/server/NetworkStoreRepository.java # network-store-server/src/main/resources/iidm.cql

Fix

afe2c5a

Signed-off-by: Geoffroy Jamgotchian <[email protected]>

geofjamg approved these changes Feb 9, 2021

View reviewed changes

geofjamg merged commit 2d5a637 into master Feb 9, 2021

geofjamg deleted the complete_persistent_iidm_implementation branch February 9, 2021 13:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Complete persistent iidm implementation #163

Complete persistent iidm implementation #163

SlimaneAmar commented Dec 11, 2020

geofjamg Feb 8, 2021

SlimaneAmar Feb 8, 2021 •

edited

Loading

SlimaneAmar Feb 8, 2021

geofjamg Feb 8, 2021

SlimaneAmar Feb 8, 2021

geofjamg Feb 8, 2021

SlimaneAmar Feb 8, 2021

geofjamg Feb 8, 2021

SlimaneAmar Feb 8, 2021

geofjamg Feb 8, 2021

sonarqubecloud bot commented Feb 9, 2021


		Graph<Integer, Edge> graph = NodeBreakerTopology.INSTANCE.buildGraph(index, voltageLevelResource);
		Graph<Integer, Edge> graph = NodeBreakerTopology.INSTANCE.buildGraph(index, voltageLevelResource, true, true);

Complete persistent iidm implementation #163

Complete persistent iidm implementation #163

Conversation

SlimaneAmar commented Dec 11, 2020

Choose a reason for hiding this comment

SlimaneAmar Feb 8, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sonarqubecloud bot commented Feb 9, 2021

SlimaneAmar Feb 8, 2021 •

edited

Loading